Date: Fri, 29 May 2020 22:33:46 +0200 From: Adriaan de Groot <groot@kde.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Lo?c Bartoletti <lbartoletti@freebsd.org> Subject: Re: svn commit: r536991 - head/net-im/telegram-desktop/files Message-ID: <16832933.sFgvYJuXru@beastie.bionicmutton.org> In-Reply-To: <202005291841.04TIft0K071945@repo.freebsd.org> References: <202005291841.04TIft0K071945@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart5320677.8gLySxXtyI Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Friday, 29 May 2020 20:41:55 CEST Lo=C3=AFc Bartoletti wrote: > Log: > net-im/telegram-desktop: prepare for Qt5-5.15 >=20 > Approved by: tcberner (mentor) > Differential Revision: https://reviews.freebsd.org/D25051 Thanks Lo=C3=AFc, it's good to have more people helping with the tidying an= d=20 patchwork before a Qt update.=20 =46or context for other developers: implicitly included header files are a= =20 problem. We all know that from Linux software that assumes that <string.h>= =20 include <errno.h>, that kind of stuff. Qt has similar deeply-hidden implici= tly=20 included headers, and some releases pare them down by introducting forward= =20 declarations. That has annoying fallout all over as the previously implicit= =20 includes need to be made explicit for software written and released against= =20 older Qt versions. The fix is harmless with older Qt, while reducing the si= ze=20 of the diff when we *do* import Qt 5.15 into the tree. I expect things like= =20 Telegram to have a release some time down the line that makes these patches= =20 obsolete again as the new release is done against the latest released Qt. So thanks again, Lo=C3=AFc, for dealing with this drudge-work. [ade] --nextPart5320677.8gLySxXtyI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEUq+pvuD+N8/vVW++WoDe9T7W/7IFAl7RcaoACgkQWoDe9T7W /7L9DRAAtab6jt4Qv0R7wdreGNiriKsgYeElPm2MQUwwTWmuxF2ejYsb6JgK5B9W 4Ryngzv51LhEELWnX++sjEx5sOEqiDG9XXx8BLKTTzq94blbbHX8gTm+WLtpBpIn t26faGsQAsZkrJP5UDeGp8cOVvN3pQ7Hz81dOBja8lAcIx3k7CSViz57vXVvazjT Mxy+DULwfdc9/xL5p3i5Wx9AzskSbNGvCZnDl6dEOQSoI0QdcUixw1SwOU7YW+DS hS+vnBopSywOxwiHyE6+jI7MCMIsT0/4o1glh3sn/t9aVAD90nITQSjOAbh39N3c ujJqXLf34V+GN7dW/yKbRnio+8KdoM57SOsol83eTEe6MYwGcGa/3ZIHaYv1Mnwl hd3/voSMFNf1Xqif+bkLbnrhuJcKDPmFhrrm6XItr89uPjFEljhkgCjUNduAQ7J0 T2xBpAqFmqUtbZ0wzlYg5zcf75LG1/8plMyOu54g6giB3oJQM0tDQ8h2maQOlHfr 5Ppv92L+3cRy+JZoRtLPsge3KgWAmgrArBUqmxiJV6Pn9ba/wF1NNzSNmTVs0Re7 BjrxLRGNtJ6eg2YJgpyGGO5K1uWXaQbN7Dl+7UhCucPZOeqy80Xu3tVBKnGu25Oi BCg/Cfxrxx2MF1k7CEDMBvvqCl6xH9amWcmEFewEnRyTI9JuhvQ= =8tJe -----END PGP SIGNATURE----- --nextPart5320677.8gLySxXtyI--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?16832933.sFgvYJuXru>