From nobody Sat May 2 15:24:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g7BXv6Pnfz6c7KV; Sat, 02 May 2026 15:24:47 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g7BXv5dglz3FfH; Sat, 02 May 2026 15:24:47 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777735487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W5pGjUtwzBWvZxRmJBe7uEWEf89rDAg6C6X4QmFDMZw=; b=msnZbz/WoaoZTBfxD7x8J1zS+qkL+b50vMmmFzqJrkqrP4teas7leqsKxsFk9AUOJFlkc6 /rIe+IjBafSzYd/0sxNNPIRp7Sq5XTFSU/yDsVlO1Ct//PfbTOJG9I+Splue5nNZFKaGJG VLOBqF0DMbNIawZN/bfiD4V72ra9Tkgg2hbVrRRw5k0YfY3mY9JA0On8Mqfe0LfbrqWs+a R/uuuuc31X+4/3w+PUSCVEzHhMRcTPBTRxKEA8Nx5F0jNH8LnOnVYhMtXDEQTqzrW5SSCx QUP5MNCsGPFIqMmI6vrSoBiIKIFrH4kJ5qsBMHnnW9OMFb9XYNxhHbvY/4BAkg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777735487; a=rsa-sha256; cv=none; b=Hwpk3kLlkCbgfx5E7NsO9zMzJgBcrr4j9oEGq+OA0qgzBq5Sh2YGF6/fhr/bwjIuZFKQ+H Kjq5+4qvTEj5F1Hr2XGULw+UoBz5ybXzBJmliG7Kp7TLP0duOpCU/ijisCPK61TlgAqOr4 uuTyiQcNmBPxCTTeuKcdrB6mNwzYYiYoK2+B21tIoas0ZdriI1Qw4bKU7RrXK8s1eU1/gK EDRVzNiNpFu9J0HavTavW4ein+6sTXQJD+1kLRrn/HqXo5flEgXyLsOrZ6X9NYJtEXrqKR s93FD3XBpTVHsIyidMHuTprFx53Rs+SRnPLo5eIbUn890rVfni7CycuZwFM/sw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777735487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W5pGjUtwzBWvZxRmJBe7uEWEf89rDAg6C6X4QmFDMZw=; b=s+ai7gzwTOHxrODyNkhH9Vv8hVUP7tLLYddDoPvez9P2WzBOkCVpyugETo1oss0mY30lYR 6QNs2KNUCJUhARBYOKTJllgugz4qNENOJ10WYJ5Dgx5X5Q14JUgDkM10aQtifD15PCnkAl LF1JXCsw6eUeyvKuVX6szAPaAizzTKS66uliAVyDQj6wHM9YvviULcb0lPyikRf7oYhbrk ILujVWvfD4gV6/7JRsAWFxOpwMvHsATwCUDlvUxVJL9zFSTbb+yLluU5RxGFXvaEaeMg47 Sr2D6TwJGEN0gmGIdJ/4J0IR+aoMn/Zvvp+D9i+yqW4AgSI5EQSY9+o6aP1RXg== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4g7BXv1gTHzL1Y; Sat, 02 May 2026 15:24:47 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Sat, 2 May 2026 08:24:42 -0700 From: Gleb Smirnoff To: Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3e845b109056 - main - ping: fix listing test cases when scapy is not installed Message-ID: References: <69f61649.1c022.73b2a773@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69f61649.1c022.73b2a773@gitrepo.freebsd.org> On Sat, May 02, 2026 at 03:20:41PM +0000, Alan Somers wrote: A> commit 3e845b1090565912375c5578cf0399d27b7fa70c A> Author: Alan Somers A> AuthorDate: 2026-05-01 23:06:35 +0000 A> Commit: Alan Somers A> CommitDate: 2026-05-02 15:20:16 +0000 A> A> ping: fix listing test cases when scapy is not installed A> A> The ATF-python test program was attempting to list test cases that A> require scapy. But it attempted to import the scapy module before the A> test cases had been listed, resulting in an ImportError that kyua A> interpreted as a test program crash. A> A> Fix this behavior by handling that ImportError well enough to list test A> cases, but not run them. If scapy isn't present, Kyua will refuse to A> run the test cases. But it needs to be able to list them in order to A> know to skip them. A> A> Sponsored by: ConnectWise A> MFC after: 2 weeks A> Reviewed by: maxim A> Differential Revision: https://reviews.freebsd.org/D56765 Sorry for not reviewing in time. I don't think Kyua expects a test program to be able to list the test cases, but then fail to run them. Isn't there a standard way of dealing with the problem? Many tests have @pytest.mark.require_progs(["scapy"]) in them. -- Gleb Smirnoff