From owner-freebsd-net@freebsd.org Fri Jan 8 17:04:50 2016 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1908EA6702C for ; Fri, 8 Jan 2016 17:04:50 +0000 (UTC) (envelope-from alex.burlyga.ietf@gmail.com) Received: from mail-vk0-x22e.google.com (mail-vk0-x22e.google.com [IPv6:2607:f8b0:400c:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CCC4D1395 for ; Fri, 8 Jan 2016 17:04:49 +0000 (UTC) (envelope-from alex.burlyga.ietf@gmail.com) Received: by mail-vk0-x22e.google.com with SMTP id a123so163979053vkh.1 for ; Fri, 08 Jan 2016 09:04:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=oJ8HpAC4egMaooM5PHHf7Nbmgr96YtpyYuYQJrpvuoU=; b=zICI1qr2xkudt+kjZRJUR5626OL5CeIGWPSLb2WRbG3i/J6lN+t1TdTyl4Bxo5QHMd 9t2ck11Nhoc754fhXgRqSIgel+Gw6gnAaTBJURYXwK/RFVOuglcDb3D3w/RVOw6x51nN Gf384uUJWyDj6n+o3Ol0dd1QkjAFnpjRkIXl35Dj/hxR5atmD6qBsDO3TFoj01y6Hu6y 3Emwt7+y2wCUeL6wjicB5/ig0gtp2K0lsT99OeLrktu/i/G1StjNw6W1MrSkgMVvQLqF kDB5F5IUIPhtS3Z+BFgAmME60bKuegMrOzqRWktFayi80y1rIlAlKyYRJjyucAJrlNpD OAIA== MIME-Version: 1.0 X-Received: by 10.31.47.88 with SMTP id v85mr80196539vkv.118.1452272688761; Fri, 08 Jan 2016 09:04:48 -0800 (PST) Received: by 10.103.108.195 with HTTP; Fri, 8 Jan 2016 09:04:48 -0800 (PST) Received: by 10.103.108.195 with HTTP; Fri, 8 Jan 2016 09:04:48 -0800 (PST) In-Reply-To: References: Date: Fri, 8 Jan 2016 09:04:48 -0800 Message-ID: Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth From: "alex.burlyga.ietf alex.burlyga.ietf" To: Ravi Pokala Cc: freebsd-net@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2016 17:04:50 -0000 Perhaps Sephe planing to use it as a sysctl? Alex. On Jan 8, 2016 07:59, "Ravi Pokala" wrote: > -----Original Message----- > > > >Date: Fri, 8 Jan 2016 02:29:22 +0000 > >From: "sepherosa_gmail.com (Sepherosa Ziehau)" > > > >To: freebsd-net@freebsd.org > >Subject: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network > > driver configurable LRO entry depth > >Message-ID: > > > >Content-Type: text/plain; charset="utf-8" > > > >sepherosa_gmail.com created this revision. > >sepherosa_gmail.com added reviewers: network, adrian, delphij, > decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, glebius. > >sepherosa_gmail.com added a subscriber: freebsd-net-list. > >Herald added a reviewer: transport. > > > >REVISION SUMMARY > > When there is only tiny amount of TCP connections and the host is slow, > e.g. in VM, holding too much TCP segments in an LRO entry will cause RX > performance degradation. We now allow network drivers to configure how > deep one LRO entry should be. > > Forgive me if I'm missing something obvious, but this patch doesn't > actually change anything - rather than hard-coding 65535, you're using > lc->lro_hiwat... which is hard-coded to 65535. > > Right? > > -Ravi (rpokala@) > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >