From owner-svn-src-all@freebsd.org Sun Jul 5 20:50:57 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83D75ADEE; Sun, 5 Jul 2015 20:50:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x231.google.com (mail-pa0-x231.google.com [IPv6:2607:f8b0:400e:c03::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 501DC1288; Sun, 5 Jul 2015 20:50:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pacws9 with SMTP id ws9so85378861pac.0; Sun, 05 Jul 2015 13:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :message-id:references:to; bh=FnJ2pV8C2PSKBdD7aAhV1bYcSNkCfXD3+n30n1b1UVU=; b=pTPaJep+v59iqh+r/TmwjoKKF8ilsayUx1UddBYW7CTPa2hUrvwFfrYB6F0yT4tRDM RnceHEcGmo0L4RY0/MxEQrS9jI4mbmxd52tPQb4fUe6KoY28M+Mp9LnC/SGwaeLi1P91 PFj5h5JB9CnK8bqs/UiueNHXid4vZy9Kqt6C85UTuGH3Qc00bZJGfUjcQXltbHIBZRlp V1+CFZFA7FtWu+CRH6/bz9DBEC1ywuOEvIOoxCLsEGgS15ri5IYtRSaf4SNAK1oSFOpg fJAf2RuIHaE/B1gJcz54+Ic5OMmpYLj7S0lqkgy4BH5GJP977Q+2UgXaJJ8LrKRpgDgR Nxaw== X-Received: by 10.70.55.165 with SMTP id t5mr84937595pdp.102.1436129456913; Sun, 05 Jul 2015 13:50:56 -0700 (PDT) Received: from [192.168.20.5] (c-98-247-240-204.hsd1.wa.comcast.net. [98.247.240.204]) by mx.google.com with ESMTPSA id td3sm15868838pab.46.2015.07.05.13.50.55 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 05 Jul 2015 13:50:56 -0700 (PDT) Subject: Re: svn commit: r285160 - head/sys/conf Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_E0FB4C41-728B-4137-8324-809E2DBA1BE8"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5 From: Garrett Cooper In-Reply-To: <495E11C2-BB42-4687-8551-604C1F14D37E@gmail.com> Date: Sun, 5 Jul 2015 13:50:54 -0700 Cc: John-Mark Gurney , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201507051415.t65EFxWd044357@repo.freebsd.org> <20150705194954.GA8523@funkthat.com> <1436126730.1191.4.camel@freebsd.org> <495E11C2-BB42-4687-8551-604C1F14D37E@gmail.com> To: Ian Lepore X-Mailer: Apple Mail (2.1878.6) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jul 2015 20:50:57 -0000 --Apple-Mail=_E0FB4C41-728B-4137-8324-809E2DBA1BE8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jul 5, 2015, at 13:49, Garrett Cooper wrote: > On Jul 5, 2015, at 13:05, Ian Lepore wrote: >=20 >> On Sun, 2015-07-05 at 12:49 -0700, John-Mark Gurney wrote: >>> Ian Lepore wrote this message on Sun, Jul 05, 2015 at 14:15 +0000: >>>> Author: ian >>>> Date: Sun Jul 5 14:15:58 2015 >>>> New Revision: 285160 >>>> URL: https://svnweb.freebsd.org/changeset/base/285160 >>>>=20 >>>> Log: >>>> Ensure all the required files get built when you include the IPSEC = option. >>>=20 >>> Umm.. This looks more like that IPSEC should require that the crypto >>> device be specified instead of fixing it this way... >>=20 >> I considered that, but rejected it given the presence of crypto | = ipsec >> on some of the files already, but not a sufficiency of them to = actually >> build sucessfully. Heavily my thinking that was a personal belief = that >> if you say "option foo" it should just work without you needing to = know >> other (likely not well documented) prerequisite options also need to = be >> set. >=20 > Or=85 just create a manpage that says =93options IPSEC=94 requires = =93device crypto=94? Oh wait =97 there already is one and it states exactly that... = https://www.freebsd.org/cgi/man.cgi?query=3Dipsec&apropos=3D0&sektion=3D0&= manpath=3DFreeBSD+10.1-RELEASE&arch=3Ddefault&format=3Dhtml . Maybe just add some comments in the KERNCONFs to note that =93options = IPSEC=94 requires =93device crypto=94? --Apple-Mail=_E0FB4C41-728B-4137-8324-809E2DBA1BE8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVmZiuAAoJEMZr5QU6S73e4GwH/j4Z3r5iNFhRzwBrEkURm6yN SNtF3UgDnNEYRB/VGJDDVNBkrglqu+aW2qgHAxqAJgbANDuOAoQW83bgmY1lOSwm JW2k/MHniKJ6TlQaycVJbk1eBawKlbAvAJsUS3hCoKS/gXS7PEwPuoDPc6fEvcYj IXJcf80aTwp4U8qRRzxqycIDg0L2gE9f5qlBjhCMw3UyGdqKDeEoTCheUA8ezSaO STRiwSWlH8mGP5aJYt5OyrVuvr0ns4r3CnmRkoKuWUOoPQaQ4or51DACGE+bP4uX scdtgp2/S+64rhBlIeIKGd0HW6rW5RxrTVEf7z9XSmCklNdXumSji+jbFvwwr3A= =+D+/ -----END PGP SIGNATURE----- --Apple-Mail=_E0FB4C41-728B-4137-8324-809E2DBA1BE8--