From owner-dev-commits-src-main@freebsd.org Tue Aug 3 20:28:05 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 08E8E650391; Tue, 3 Aug 2021 20:28:05 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GfRJh6TPQz3rkb; Tue, 3 Aug 2021 20:28:04 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id AF119C1E0; Tue, 3 Aug 2021 20:28:04 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from dummy.faircode.eu (10.246.39.62.rev.sfr.net [62.39.246.10]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aniel.nours.eu (Postfix) with ESMTPSA id 96CD64D875; Tue, 3 Aug 2021 22:28:02 +0200 (CEST) Date: Tue, 3 Aug 2021 20:28:01 +0000 (UTC) From: Baptiste Daroussin To: "Rodney W. Grimes" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-ID: <1acb127e-1d2c-4c9f-96e6-23bfbf9695ac@FreeBSD.org> In-Reply-To: <202108031732.173HWXr9049195@gndrsh.dnsmgr.net> References: <202108031732.173HWXr9049195@gndrsh.dnsmgr.net> Subject: Re: git: 184d64af1344 - main - locales: stop hardcoding the directories in the mtree MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <1acb127e-1d2c-4c9f-96e6-23bfbf9695ac@FreeBSD.org> X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2021 20:28:05 -0000 3 ao=C3=BBt 2021 19:32:44 Rodney W. Grimes : >> The branch main has been updated by bapt: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D184d64af1344d6f3c37049951= 0cede49320f4863 >> >> commit 184d64af1344d6f3c370499510cede49320f4863 >> Author:=C2=A0=C2=A0=C2=A0=C2=A0 Baptiste Daroussin >> AuthorDate: 2021-08-03 12:25:00 +0000 >> Commit:=C2=A0=C2=A0=C2=A0=C2=A0 Baptiste Daroussin >> CommitDate: 2021-08-03 12:25:00 +0000 >> >> =C2=A0=C2=A0=C2=A0 locales: stop hardcoding the directories in the mtree >> =C2=A0=C2=A0=C2=A0 >> =C2=A0=C2=A0=C2=A0 The framework knows how to create directories and tag= them properly >> =C2=A0=C2=A0=C2=A0 for a the creation of a mtree, not need to hardcode a= ll the locales >> =C2=A0=C2=A0=C2=A0 entries in bsd.usr.mk >> =C2=A0=C2=A0=C2=A0 >> =C2=A0=C2=A0=C2=A0 This simplifies addition of new locales but also allo= w people building >> =C2=A0=C2=A0=C2=A0 with WITHOUT_LOCALES to end up with a directory full = of empty files > > The uses of /etc/mtree go beyond the simple directory creation, > please cause something to build a BSD.locale.dist file and install > it in /etc/mtree to replace the functionality removal you have > just performed. > > Thanks, > Rod > Please provide a valid use case not working anymore after this change and I= will consider. Note that this is not the only part of the tree where the same thing is don= e. Best, Bapt