From owner-svn-ports-all@FreeBSD.ORG  Mon Dec  3 11:14:05 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 41097B3C;
 Mon,  3 Dec 2012 11:14:05 +0000 (UTC)
 (envelope-from gahr@FreeBSD.org)
Received: from cpanel09.rubas.ch (cpanel09.rubas.ch [195.182.222.79])
 by mx1.freebsd.org (Postfix) with ESMTP id 8775E8FC0C;
 Mon,  3 Dec 2012 11:14:04 +0000 (UTC)
Received: from 98-41.199-178.cust.bluewin.ch ([178.199.41.98]:61722
 helo=gahrfit.gahr.ch)
 by cpanel09.rubas.ch with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
 (Exim 4.80) (envelope-from <gahr@FreeBSD.org>)
 id 1TfTyN-000R9U-1U; Mon, 03 Dec 2012 12:14:03 +0100
Date: Mon, 3 Dec 2012 12:13:59 +0100
From: Pietro Cerutti <gahr@FreeBSD.org>
To: Alex Dupre <ale@FreeBSD.org>
Subject: Re: svn commit: r308132 - head/audio/amrcoder
Message-ID: <20121203111359.GB86596@gahrfit.gahr.ch>
References: <201212031034.qB3AYpkL004754@svn.freebsd.org>
 <20121203105040.GA30670@FreeBSD.org>
 <20121203105616.GA86596@gahrfit.gahr.ch>
 <50BC8788.3090405@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="zx4FCpZtqtKETZ7O"
Content-Disposition: inline
In-Reply-To: <50BC8788.3090405@FreeBSD.org>
X-PGP-Key: 0x9571F78E
X-PGP-Fingerprint: 1203 92B5 3919 AF84 9B97 28D6 C0C2 6A98 9571 F78E
User-Agent: Mutt/1.5.21 (2010-09-15)
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - cpanel09.rubas.ch
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - FreeBSD.org
Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: gahr@FreeBSD.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2012 11:14:05 -0000


--zx4FCpZtqtKETZ7O
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2012-Dec-03, 12:05, Alex Dupre wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>=20
> Pietro Cerutti ha scritto:
> > I see no reason, however, not to let the author supersede them with
> > more appropriate flags.
>=20
> If they were appropriate, why have you changed them? :-) This is the
> exact reason why we want the user set these optimization flags. When
> there is a really good motivation to add higher optimization flags
> usually we have OPTIMIZED_CFLAGS OPTION.

Fair enough. After re-reading [1] I realize that optimization flags are
to be treated differently (i.e., removed) than other flags an author
might want to set.

[1] http://www.freebsd.org/doc/en/books/porters-handbook/book.html#dads-cfl=
ags

Thanks danfe and ale for the review!

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--zx4FCpZtqtKETZ7O
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlC8iXcACgkQwMJqmJVx9467YgCdFaw5wTl90N8JeNAOL+Yv+jhP
CJQAoLbZV2qimXOgpUejtHlPPKjTVgnI
=WSA3
-----END PGP SIGNATURE-----

--zx4FCpZtqtKETZ7O--