From owner-freebsd-net@freebsd.org  Fri Feb  5 01:14:03 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7012FA9D771
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Fri,  5 Feb 2016 01:14:03 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from phabric-backend.rbsd.freebsd.org (unknown
 [IPv6:2607:fc50:2000:101::1bb:73])
 by mx1.freebsd.org (Postfix) with ESMTP id 5CBDEB15
 for <freebsd-net@freebsd.org>; Fri,  5 Feb 2016 01:14:03 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by phabric-backend.rbsd.freebsd.org (Postfix, from userid 1346)
 id 58B3610799E; Fri,  5 Feb 2016 01:14:03 +0000 (UTC)
Date: Fri, 5 Feb 2016 01:14:03 +0000
To: freebsd-net@freebsd.org
From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org>
Reply-to: D5185+325+ec92cccb639ec0fa@reviews.freebsd.org
Subject: [Differential] [Commented On] D5185: tcp/lro: Allow network drivers
 to set the limit for TCP ACK/data segment aggregation limit
Message-ID: <47c267ddddb7d0405fff0ce47250d91a@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D5185: tcp/lro: Allow network drivers to set the limit for TCP
 ACK/data segment aggregation limit
X-Herald-Rules: <64>
X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye>
X-Phabricator-To: <PHID-PROJ-62ihepuxzgyzg7rh5uic>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-To: <PHID-USER-sqhepmmg5rsjiyy5slol>
X-Phabricator-To: <PHID-USER-aojo5yplx3m2nkpgwndr>
X-Phabricator-To: <PHID-USER-57eqaez2c2qhlyhs4xoi>
X-Phabricator-To: <PHID-USER-4lzxzqflpaankb5hk2y4>
X-Phabricator-To: <PHID-USER-mdwvnzzsrozqcmzhmbra>
X-Phabricator-To: <PHID-USER-mqlw6f5jjiqhbs4co7yd>
X-Phabricator-To: <PHID-PROJ-u7z45dkhkb4gc5luse77>
X-Phabricator-To: <PHID-USER-3chbbds7jbl2e23f44bm>
X-Phabricator-Cc: <PHID-USER-6ps3unnxvniqcn5kdjn5>
X-Phabricator-Cc: <PHID-USER-dyyyzfp34mimhzvg33tk>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-wthfupxgtart42sdknmd-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-wthfupxgtart42sdknmd-req@FreeBSD.org>
Thread-Index: NTU0NmM0Mjk2NjdmNzVhNmM3MzlkMWQyNTdmIFaz91s=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Feb 2016 01:14:03 -0000

sepherosa_gmail.com added a comment.


  I will adjust the patch accordingly.

INLINE COMMENTS
  sys/netinet/tcp_lro.c:655 Sure :)
  sys/netinet/tcp_lro.c:684 Sounds fine to me.  I did the byte limit before (https://reviews.freebsd.org/D4825).  But it turns out the ACKs need seperate limit (append count based).  To make them consistent, I changed the original patch to use append count too.

REVISION DETAIL
  https://reviews.freebsd.org/D5185

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, hselasky, np, transport, gallatin
Cc: freebsd-virtualization-list, freebsd-net-list