From owner-freebsd-hackers  Mon Jun  5 19:32:17 1995
Return-Path: hackers-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id TAA21489
          for hackers-outgoing; Mon, 5 Jun 1995 19:32:17 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id TAA21479
          for <hackers@freebsd.org>; Mon, 5 Jun 1995 19:32:12 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id TAA25146; Mon, 5 Jun 1995 19:30:29 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199506060230.TAA25146@gndrsh.aac.dev.com>
Subject: Re: kernel page fault while doing tar to /dev/rft0
To: bde@zeta.org.au (Bruce Evans)
Date: Mon, 5 Jun 1995 19:30:29 -0700 (PDT)
Cc: steve2@genesis.tiac.net, hackers@freebsd.org
In-Reply-To: <199506060206.MAA19355@godzilla.zeta.org.au> from "Bruce Evans" at Jun 6, 95 12:06:46 pm
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1142      
Sender: hackers-owner@freebsd.org
Precedence: bulk

> 
> >>   #endif
> >> + 	fdblk = 128 << (fd->ft->secsize);
> >> + 
> 
> >Still will crash some ones system if they get to here with out a
> >ft device since ft will be null!!  Now maybe the open code stops
> >them from getting here, I am not sure :-(.
> 
> >>   	if (!(bp->b_flags & B_FORMAT)) {
> >>   		if ((fdu >= NFD) || (bp->b_blkno < 0)) {
> >>   			printf(
> >> 
> 
> >How come fdblk size is coming from the ft structure, but is used in
> >non ft code???  See line 1108, 1118, and 1120.  Perhaps the real bug
> 
> ft is a pointer to the floppy t_y_pe structure.

Ah.. okay, suggest we rename it to type then!  fd->type->secsize makes
a lot more since when reading this code!!!

> >Fails my visial, this patch has been rejected for inclusion at this
> >point in time :-(.
> 
> Patches should be reviewed by someone (if any :-) who is familiar with
> the code.

Agreed, but it still fails on the fact the hunk is offset which means
the purson is not testing against -current code.


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                   Custom computers for FreeBSD