From owner-svn-src-head@freebsd.org Sun Aug 19 19:12:28 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4648010751DA; Sun, 19 Aug 2018 19:12:28 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D9364869B4; Sun, 19 Aug 2018 19:12:27 +0000 (UTC) (envelope-from delphij@FreeBSD.org) Received: from odin.corp.delphij.net (unknown [IPv6:2601:646:8882:37a:d463:7d7:dec2:3842]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: delphij/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 3AECB1B470; Sun, 19 Aug 2018 19:12:27 +0000 (UTC) (envelope-from delphij@FreeBSD.org) To: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201808191740.w7JHeoSj052259@repo.freebsd.org> <1534703254.27158.41.camel@freebsd.org> From: Xin Li Openpgp: preference=signencrypt Autocrypt: addr=delphij@FreeBSD.org; prefer-encrypt=mutual; keydata= xsFNBFJNzwQBEACuPNSJjL/AD8oHFuG72vtx5P7Q6dpiEbFABgw/IohS65yDZDd3qFH9ssQv AsFafwB/ofsk6t7dx6zIC05dv5qjhGIOKSJxFC4U1HAot9+QpeUG+8boTKZiiycrMruItj2U JANlv+gN5h0mAsL5f9eNzhRM43kdjN8cQnBIujhO54Derjnrnqz6cQtoonV6SvvVJZUQGxHK 5R1XYJ6wiTuvoEuRYnNObJmPFWZyYOaGZz0qqD6Qe1BhkZuRzv2bZxwJc3Raap/GF6Pm9J/c hlYHUmm2QLaXvmoP8WNosNjla1fup0tgYQE+7MTtHFVxmVj9ZTihN3rEL5IkeEKjQAqcpe1n Db8X2o4K262LRpFl8WtVMW2TfN5Avpj+knZMl3tkYGvYK/nfadCr6Af4co9mkhX6QYgkerg2 mXEGaQzSD/omnsxHCfqMgdphaX3B3eoY2Fv36BMpjSdHmm0rmwqjqZaqlZn89vQ/I6ATvLyx JsdHwTbrj57audl/RKC+OpREOJPaVULp1L+9zdBXslILO8MJaT6YEw1T29bEj5jvLm03Y4rF u/YTruHcMPpsGbpJckDKiy6ISAbMtPvz7/KR91xPHS6KExGiIakIX9xpIXIDKgq+ecEWwkFK PogoKqO6K0/GYkTRoKdXGzsILvIurtbPqSFqWzbRIyNOa82jowARAQABzRZYaW4gTGkgPGRA ZGVscGhpai5uZXQ+wsF9BBMBCgAnBQJTQvBFAhsjBQkJZgGABQsJCAcDBRUKCQgLBRYCAwEA Ah4BAheAAAoJEJW2GBstM+nsha4P/2Roa/REjZLZlIG1TKOxEDqmwc3fynX4w2g7/FXA7f7Z YO5N4vnnnQdJbDZDt4TJtiP1NHHdheQ5+loJrrCXVlU31LuJv1ebM2Ajsuo/0l3tfulEf6Ki GoozmaNZAhwiGJkQVg9DSKsea5xIA31lPnFH4T0SKn8Q6F4HYienmJJtlKVTADvYXA+DRmv0 rNOyVe+V/AuTFuelKg3Ua5a+dY3oqtrQQvFS4n7iIrNjEMUBVx0XTrYLddnF+YjXDg5Phf0D pV/2yJOXiTGiZMK6i7vwHZkJvarACoTSrUrr6OBuZv5Gf87VgifZKLr2Fuf+FePiVCoZTQiL 0hPQyABMzeWa32P6BY2LBMMMFvFiyL5pN5k6nJ0nx4skl8UxZ5ay4yyVg2u3f4aI3+m0XlZ+ iixrjmCTGi1s+d/n6E3eFXdJUUbSOXLZaU4qrbXRzTYCZmZViryv7ibtOHXnG6oWy7BFEHuT rUW6OBvsQDTp5iQ6opENJ5/ZzSA3c5p1WS9Ezv4Bpdqcm7LTQX2j6kXikj8YqICtDF2rkKZ2 Ynjm9se9B0h/T1SOaSpbtRg05UKjsinDq2x8EeX21yFs3UyvwePLrGoNKL45EJM0xwxrnlfr M0ayKJNLoYysY78d54hg7XMmkQD/oZz9I+k4fN6CmZ2i5WGH2BgYs0313JMHxSg7zsFNBFJN zwQBEADPtS+nfTKM6PwgSWLDGVgUYQ/RLaKzCcpQAf4ryLBugXpx3s2BBT1bixX7CpsLXKQi +RRETgSFzDaBL9SEs2ZDV2YT+zGp08aijK/Yl9+RIeezAukI3c+XMHuo8ktUWJmo5/1DX07q G30ckG7uFuTnt31sFzwhh/ZeSuLFyel/fWF48KExLDIVa8DyEUJaYvE9Vfph4T/3LkKuzVTy +iwUBLiSLj5G5N70A+4usbL3eKyYrJqCSaLfrP99/nlgBhMAHVcKcv0uqSuiaH9OMqg1VjQs N8j6NDQug9QrbBTM6U7oZWF/AK+CdFoe+leq5MZfzwCevs0BQgxWm4SHMpXL2vtly67QSPMY dl96fOzw8YbKHv1o0ixhCvc37cI9oUVuSJLXKhEEAvWvLuusiuNeoz+6aPlELvD8h5txJqui tVOzctvJ7ktGZTNiz73tKYVdkKaQVyo8QJFLCNLnUulrQ5wXwteYPg6mrpBxu9VqgDrMp7eB T2kaZ4GRBoMWXXPYSIEe5PM5hhNCsSUfqrKj34UZPijPe+HiWoFJ4S5vIpzutiae11Ctki7u XzeLAhOJQB2raraIqDlFP9I9Zj9JOAZhmiKSEWKfOooCNxQYGiUdPrdYnAe+m7FXRomjF0OO gSepNIESt2gOEIbE5cMxQ0gAueNJc58eHCjWhsNJIwARAQABwsFlBBgBCgAPBQJSTc8EAhsM BQkJZgGAAAoJEJW2GBstM+nsh8EP/1sxZpkJelu+smmqaqdrGHlNrFVLOmeN5yr2IGHBUbmF htjr7fVoU8T0mUnlUU724aKPla4nWhMb4NMu+VxRRFGaT2TYpyR6VIxaStycyUdMGjdXV0Pz TGmxFXhNZXKEITXH9sIxuONBp1czl4AgwN7AAl1MKyV13AaLIyajs58mYmuXtyFn/O+4lxh5 nl2Fa3L9YkL9O7QU2p6WAnDky+L3PgUWp1AzJGfYlLZ8XXCi+KK+pnta+f9yKHt/Oqd/s7OC W4mXgFkBrfuSZZofa4eZckh5u0yBYW3OnEJhClgxRbuOhyYwqQr5oxPrQtjtbMiBzbrOkHhy NnrVCFd9EqlojREGDefHo3V+ZlUOc6OoN3CAYnNa2uLEOm5DCuqOE4z5atBCih5EyITPp7JP J2disEP6ddipcilqbnJdP+TyRQwSv5qRNy8cHahD1Cg9XJJHiC3qr+W3eOtqPkJxhU5biPEr 7dljaLS1Ij771brzqO/x5zW1L9py7muXzYBsW8+keKj8LOYs2242KgjI5Og9YhIJGBFBNddQ wxKBKQpytKQOiXwjhk4Nj77U796bsCd/jIS0r0ZUKBEptPyKso7ncfrm163aEmSaDUkiIjyp 9CEOVT87D+VAVh9PyLGP1niQzWEWFSK36tRGZlF0odP1ZB6wub9zq2DxFouSjHgH Organization: The FreeBSD Project Subject: Re: svn commit: r338059 - in head: . contrib/ntp/lib/isc contrib/ntp/sntp/libevent crypto/heimdal/lib/roken crypto/openssh include lib/libc/gen lib/libc/include sys/crypto/chacha20 Message-ID: <2012d319-ef2b-d734-5f1a-7b11d9511024@FreeBSD.org> Date: Sun, 19 Aug 2018 12:12:25 -0700 User-Agent: Thunderbird MIME-Version: 1.0 In-Reply-To: <1534703254.27158.41.camel@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HpnDT9IALga4s6AAzS10JJ8WFF6frutrF" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2018 19:12:28 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HpnDT9IALga4s6AAzS10JJ8WFF6frutrF Content-Type: multipart/mixed; boundary="jScKxObTQ7OxANfKZokTRg4DqRAxvR03P"; protected-headers="v1" From: Xin Li To: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <2012d319-ef2b-d734-5f1a-7b11d9511024@FreeBSD.org> Subject: Re: svn commit: r338059 - in head: . contrib/ntp/lib/isc contrib/ntp/sntp/libevent crypto/heimdal/lib/roken crypto/openssh include lib/libc/gen lib/libc/include sys/crypto/chacha20 References: <201808191740.w7JHeoSj052259@repo.freebsd.org> <1534703254.27158.41.camel@freebsd.org> In-Reply-To: <1534703254.27158.41.camel@freebsd.org> --jScKxObTQ7OxANfKZokTRg4DqRAxvR03P Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 8/19/18 11:27, Ian Lepore wrote: > On Sun, 2018-08-19 at 17:40 +0000, Xin LI wrote: >> Author: delphij >> Date: Sun Aug 19 17:40:50 2018 >> New Revision: 338059 >> URL: https://svnweb.freebsd.org/changeset/base/338059 >> >> Log: >> =C2=A0 Update userland arc4random() with OpenBSD's Chacha20 based >> arc4random(). >> =C2=A0=C2=A0 >> =C2=A0=C2=A0=C2=A0=C2=A0ObsoleteFiles.inc: >> =C2=A0=C2=A0 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Remove manual pages for arc4random= _addrandom(3) and >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0arc4random_stir(3). >> =C2=A0=C2=A0 >> =C2=A0=C2=A0=C2=A0=C2=A0contrib/ntp/lib/isc/random.c: >> =C2=A0=C2=A0=C2=A0=C2=A0contrib/ntp/sntp/libevent/evutil_rand.c: >> =C2=A0=C2=A0 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Eliminate in-tree usage of arc4ran= dom_addrandom(). >> =C2=A0=C2=A0 >=20 > If we don't feed changes for this back upstream, we're going to have to= I'll send these to upstream. > carry diffs from mainline ntpd forever now. The upstream project is > receptive to taking diffs from us, but I guess we'd have to figure out > how to write some autotools detection to create some new HAVE_xxxx > variables for wrapping these calls. Calling arc4random_stir() is not required since ~2000. > Also, does this imply that the ntpd port will fail to build now? I > would imagine removing such fundamental routines would affect many > ports. Not right now (due to the existence of stdlib.h shims). > All in all, if it's just a matter of our implementation not needing > these functions, wouldn't it be better to implement them as no-ops and > document them as such existing only to aid porting existing code? They are implemented as ABI shims but my intention (bug 230756) is to remove the obsolete APIs (after a full exprun and have the callers fixed, of course). It's reasonable to provide ABI compatibility (they will remain) but we should fix ports if they are still doing something that is not needed ~18 years ago :) Cheers, --jScKxObTQ7OxANfKZokTRg4DqRAxvR03P-- --HpnDT9IALga4s6AAzS10JJ8WFF6frutrF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJbecEZAAoJEJW2GBstM+nsyIUP/1rIc+sHC3pKpqFzIPi1mVK9 QYCfhY/jZ+TSxFP5DyHCS6D2/3ixowrCN6Qw/lssriV3asmPcmuLnY+n+OKUENF/ gxdI/77gOWw0olVx+5kWOHn5KMfIXt6s39oWRU6X771iVOpaFrhdXIjnTXna3GVv exS8F29l4DwJyfgb8xDq1HEV19g1ZD38SgCQ/iBXHdAj23NEEKL+f/By2WDagi+R DSH/Y95SDVrQz9znzB4XKeJ+zMy5uyzP3h560tan2ybVuqJrNxHTUyQxCgw8Ga6b P5s7ztgjlweXf3cdzNSUnHcYUAUyeqLfU9PNVNSRabIc21aBoWZo4Fkum83sQ2bh okHupDpXm309vAPPcISv7y34gV4s70++BJ9e9MVLBXxW3pk0/0cXmHkVJxo+xrsY 9toR6uHjAXjA+MH0Sw097diKgAefIK2vXZJQ1+zyMsTtmGxVPUv7D7u86quUe03Z f6q1zTeb4D3aejgF1auPPLdwjJX257fSr8J3sTCbis2f/ktvFDPdvV+gD3YNhJmW BPJLgGKjeykjWdlmj1fZarxgtYQPDGyGSjV8JJSb8ykj/711/JvVSa7JQifoRaRe 7MAhT0GIb40EHBfZc63frB5b9Iv2VqUddKjTRYNORkrk/pwkKUPFvKh1/KgP8ij/ VTb56rUXVEQy7jDvwJ27 =uP73 -----END PGP SIGNATURE----- --HpnDT9IALga4s6AAzS10JJ8WFF6frutrF--