From owner-freebsd-sparc64@FreeBSD.ORG  Sat Jan  5 01:32:26 2013
Return-Path: <owner-freebsd-sparc64@FreeBSD.ORG>
Delivered-To: freebsd-sparc64@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id A560EC4D
 for <freebsd-sparc64@freebsd.org>; Sat,  5 Jan 2013 01:32:26 +0000 (UTC)
 (envelope-from lidl@hydra.pix.net)
Received: from hydra.pix.net (hydra.pix.net [IPv6:2001:470:e254::3c])
 by mx1.freebsd.org (Postfix) with ESMTP id 821D1231
 for <freebsd-sparc64@freebsd.org>; Sat,  5 Jan 2013 01:32:26 +0000 (UTC)
Received: from hydra.pix.net (localhost [127.0.0.1])
 by hydra.pix.net (8.14.5/8.14.5) with ESMTP id r051WOEl031557;
 Fri, 4 Jan 2013 20:32:24 -0500 (EST)
 (envelope-from lidl@hydra.pix.net)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.97.6 at mail.pix.net
Received: (from lidl@localhost)
 by hydra.pix.net (8.14.5/8.14.5/Submit) id r051WOAA031556;
 Fri, 4 Jan 2013 20:32:24 -0500 (EST) (envelope-from lidl)
Date: Fri, 4 Jan 2013 20:32:24 -0500
From: Kurt Lidl <lidl@pix.net>
To: Marius Strobl <marius@alchemy.franken.de>
Subject: Re: smartmontools panics 9.1-RELEASE on sunfire 240
Message-ID: <20130105013224.GA31361@pix.net>
References: <20130104051914.GA22613@pix.net>
 <20130104235336.GB37999@alchemy.franken.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130104235336.GB37999@alchemy.franken.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-sparc64@freebsd.org
X-BeenThere: freebsd-sparc64@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting FreeBSD to the Sparc <freebsd-sparc64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-sparc64>, 
 <mailto:freebsd-sparc64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sparc64>
List-Post: <mailto:freebsd-sparc64@freebsd.org>
List-Help: <mailto:freebsd-sparc64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
 <mailto:freebsd-sparc64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Jan 2013 01:32:26 -0000

On Sat, Jan 05, 2013 at 12:53:36AM +0100, Marius Strobl wrote:
> Uhm, probably an userland buffer which isn't even 16-bit aligned.
> If that's the cause, the attached patch hopefully should at least
> prevent the panic. If it does, smartmontools still need to be fixed
> though.

You patch prevents the panic from happening.
When I try to start smartd now, it reports:

root@host-98: /usr/local/etc/rc.d/smartd onestart
Starting smartd.
smartd: cam_send_ccb: Invalid argument
/usr/local/etc/rc.d/smartd: WARNING: failed to start smartd

I had updated the kernel on the machine to 9-STABLE, and
verified that without this patch, the crash still happened with
a 9-STABLE kernel, in addition to 9.1-RELEASE kernel.

My kernel now identifies itself as:
FreeBSD 9.1-STABLE (GENERIC) #1 r245044:245048M: Fri Jan  4 20:19:50 EST 2013

-Kurt

> Index: cam_periph.c
> ===================================================================
> --- cam_periph.c	(revision 245046)
> +++ cam_periph.c	(working copy)
> @@ -744,6 +744,9 @@ cam_periph_mapmem(union ccb *ccb, struct cam_perip
>  		if ((ccb->ccb_h.flags & CAM_DIR_MASK) == CAM_DIR_NONE)
>  			return(0);
>  
> +		if ((uintptr_t)ccb->ataio.data_ptr % sizeof(uint16_t) != 0)
> +			return (EINVAL);
> +
>  		data_ptrs[0] = &ccb->ataio.data_ptr;
>  		lengths[0] = ccb->ataio.dxfer_len;
>  		dirs[0] = ccb->ccb_h.flags & CAM_DIR_MASK;

> _______________________________________________
> freebsd-sparc64@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64
> To unsubscribe, send any mail to "freebsd-sparc64-unsubscribe@freebsd.org"