From owner-freebsd-ports@FreeBSD.ORG Wed Oct 19 01:16:33 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 40B671065677 for ; Wed, 19 Oct 2011 01:16:33 +0000 (UTC) (envelope-from glarkin@FreeBSD.org) Received: from mail1.sourcehosting.net (mail1.sourcehosting.net [74.205.51.45]) by mx1.freebsd.org (Postfix) with ESMTP id 16AB18FC0C for ; Wed, 19 Oct 2011 01:16:32 +0000 (UTC) Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=cube.entropy.prv) by mail1.sourcehosting.net with esmtp (Exim 4.73 (FreeBSD)) (envelope-from ) id 1RGKlg-000Huw-Kt for freebsd-ports@freebsd.org; Tue, 18 Oct 2011 21:16:31 -0400 Received: from v104.entropy.prv (v104.entropy.prv [192.168.1.104]) by cube.entropy.prv (Postfix) with ESMTP id AFAC453EE024 for ; Tue, 18 Oct 2011 21:16:26 -0400 (EDT) Message-ID: <4E9E24EA.2060105@FreeBSD.org> Date: Tue, 18 Oct 2011 21:16:26 -0400 From: Greg Larkin Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.23) Gecko/20110920 Lightning/1.0b2 Thunderbird/3.1.15 MIME-Version: 1.0 To: freebsd-ports@freebsd.org References: <20111019004528.GA3859@rwpc13.mby.riverwillow.net.au> In-Reply-To: <20111019004528.GA3859@rwpc13.mby.riverwillow.net.au> X-Enigmail-Version: 1.1.1 OpenPGP: id=1C940290 X-SA-Exim-Connect-IP: 68.189.245.235 X-SA-Exim-Mail-From: glarkin@FreeBSD.org X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail1.sourcehosting.net X-Spam-Level: *** X-Spam-Status: No, score=3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_PBL, RCVD_IN_RP_RNBL, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC, TVD_RCVD_IP autolearn=no version=3.3.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SA-Exim-Version: 4.2 X-SA-Exim-Scanned: Yes (on mail1.sourcehosting.net) Subject: Re: databases/postgresql84-server 8.4.9 rc.d script broken X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: glarkin@FreeBSD.org List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2011 01:16:33 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/18/11 8:45 PM, John Marshall wrote: > After upgrading databases/postgresql84-server from 8.4.8_1 to 8.4.9, the > rc.d script vomits thus: > > rwsrv03# /usr/local/etc/rc.d/postgresql start > su: unknown login: %%PG_USER%% > > Presumably the updated port is missing a substitution edit but I haven't > found where. > Hi John, Apply this patch to the Makefile and reinstall postgres: - ------------------------------------------------------------------ - --- Makefile.orig 2011-10-18 21:07:27.000000000 -0400 +++ Makefile 2011-10-18 21:10:41.000000000 -0400 @@ -287,13 +287,8 @@ SUB_FILES+= pkg-message${PKGNAMESUFFIX} PKGMESSAGE= ${WRKSRC}/pkg-message${PKGNAMESUFFIX} . endif - -. if exists(${FILESDIR}/pkg-install${PKGNAMESUFFIX}.in) - -SUB_FILES+= pkg-install${PKGNAMESUFFIX} - -SUB_LIST= PG_GROUP=$(PG_GROUP) \ - - PG_USER=$(PG_USER) \ - - PG_UID=$(PG_UID) +SUB_LIST= PG_USER=$(PG_USER) PLIST_SUB+= PG_USER=$(PG_USER) - -. endif .endif .if !defined(NO_BUILD) - ------------------------------------------------------------------ The Makefile depended on the presence of a file that was removed in the last commit. Because of that, the substitutions were no longer added to SUB_LIST. I'll open a PR tomorrow, if someone doesn't get to it before me. Hope that helps, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/cpucycle/ - Follow you, follow me -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk6eJOkACgkQ0sRouByUApBxGQCeKBCKeU54O1tM+59bgcDOq4mL m0UAn0ViZlz8InU+tOYQXkD2QiRVAh0M =ZNsK -----END PGP SIGNATURE-----