From owner-cvs-all Mon Aug 20 10:26:27 2001 Delivered-To: cvs-all@freebsd.org Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169]) by hub.freebsd.org (Postfix) with ESMTP id E2C5F37B40E; Mon, 20 Aug 2001 10:26:17 -0700 (PDT) (envelope-from ken@panzer.kdm.org) Received: (from ken@localhost) by panzer.kdm.org (8.9.3/8.9.1) id LAA71174; Mon, 20 Aug 2001 11:26:06 -0600 (MDT) (envelope-from ken) Date: Mon, 20 Aug 2001 11:26:06 -0600 From: "Kenneth D. Merry" To: Brian Somers Cc: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: cvs commit: src/lib/libdevstat devstat.c Message-ID: <20010820112605.A70981@panzer.kdm.org> References: <200108201640.f7KGeGU87252@hak.lan.Awfulhak.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <200108201640.f7KGeGU87252@hak.lan.Awfulhak.org>; from brian@Awfulhak.org on Mon, Aug 20, 2001 at 05:40:16PM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Aug 20, 2001 at 17:40:16 +0100, Brian Somers wrote: > > On Mon, Aug 20, 2001 at 05:45:02 -0700, Brian Somers wrote: > > > brian 2001/08/20 05:45:02 PDT > > > > > > Modified files: > > > lib/libdevstat devstat.c > > > Log: > > > Handle snprintf() returning -1. > > > > > > MFC after: 2 weeks > > > > > > Revision Changes Path > > > 1.9 +5 -3 src/lib/libdevstat/devstat.c > > > > Uhh, any particular reason you didn't send me mail about this? > > > > (from libdevstat/Makefile) > > > > MAINTAINER=ken@FreeBSD.ORG > > > > Your subsequent change, in particular, is a good bit more involved, and > > neither you nor Bruce saw fit to send me any mail about it. > > To be absolutely honest, I didn't even look for MAINTAINER flags. I > was under the impression that MAINTAINER means that you have an > interest in this code and would like to be notified of any changes > in case you know of a better way of doing it or in case they conflict > with local changes that you haven't yet committed. It bothers me that you didn't even look to see if there was a maintainer for the code. With the first commit it is understandable, since it was small. The second commit, however, was more involved. It should be obvious that the code has been changing recently, since I last made a commit just a couple of days ago. > If this is the case, then please feel free to back out my changes and > apply your own. I can then make a mental note not to do the MFC. I will be changing it, at least, since there are some style and cut-n-paste bogons in the code you committed. > BTW, I appreciate that this message sounds somewhat arrogant, but > IMHO the MAINTAINER bit is not meant to prevent progress but rather > to improve coherency for a given piece of software. I agree, the maintainer bit should not prevent progress. As I said above, if your first commit were the only one, I probably wouldn't have said anything. I don't complain when the doc folks go through and fix up man pages that I have written, etc. Not that I would do this, but how would you feel if I started spamming ppp without talking to you about it? Ken -- Kenneth Merry ken@kdm.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message