From nobody Mon Jan 12 17:19:28 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dqfJ11qFmz6NrL8 for ; Mon, 12 Jan 2026 17:19:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dqfJ04TCJz420l for ; Mon, 12 Jan 2026 17:19:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768238368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nbLenJjE8exOo4ZO1Tw+KroP6mXRJ1JUEIQ0KiOmbMQ=; b=ja36DB6iTKhHObgohys5TBD3hsnwFrE+Dnm1u5gQWqFNpR1lzI3MAf+/sgiPbn5woJZCC7 KloQ5UnBC6YcX/jwuuxs7xDn2A99Q/Uc15zSldF9RePcedTeowrli4CkiQarR3Vi4zDFiY kynpP7FWN7sO+9FNefQgCYZl7v3e7lg+yqEpSHwPBGooSCRW/5VwG2jbkccR7e7vHtrZJ8 m1KhcyjhvsQ1DnX77rlaxeovUI448xvoDNTFx+OW86Ug5M2asR6+uaGMVC346dIbJfKso7 zBVDiayBiOYLDsIplGdVwXgXq6kUEY2jooJyg6S4BFrlQXACO96mlmWEZhH1ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768238368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nbLenJjE8exOo4ZO1Tw+KroP6mXRJ1JUEIQ0KiOmbMQ=; b=wxYHQDwA1ONfF1zfJlYcbQERBWV5lZ6JOlbEFzpNFzXmCEpq3D7mt6HRVwfb+yr8ua41yg +sQ9hC+kJo3onyftimpOSd/Igr4cONXIr6VK/Y+orxa6yYfAn4plCulbofPsFS0YHtK3m3 EjRpqb4iaiDfCPxwoL2Lybca6+OHohLABmrj1B1OX3eEMIrngQ8LmscC7abBWLnIVZT7Rd bZ7L6rdjbFhhAHYONpQVi4dC4KiQwfvWOxPYR9NdGiBFepRzLGUSmwH344Xj+PymA5vItO NqmdR2VMgKlTI9CNImWZ9YmI5DEr7YoDTnMp0gUQJxvB/ZVj2kpOK/0qU+zEuw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768238368; a=rsa-sha256; cv=none; b=W9xVKLq3laI5iL64CUxu5uRHS3M0H4kbiRL7NiceRMUJxnuIccHu0NQYXLNISXsazpoTJ0 tzoTAbm8Ig3UQoPNxtGHlMhtYXQ7NlDjH89BqT037qEd6lXp4khdqeK+r1NsFzjWAF+n9Q cSNRJ1vUAZI+eQHq0+D4anT2K/NSwnlnTuQ+Pu7sXpCc+kuana94+C2dyHT5S7IuASxqxv QItGPNo7QLAO3krQHpuJltGOXLQpnonlT/NflQD2p8cTnxr71Uug0ht4bESEqKey4WBVLp SjJEK87V949ZQs7eFdby7V0D7ZKhmLYN++7zVvSPfFlqnVFjmk/bV+DiOEWZ/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dqfJ040GWzcLJ for ; Mon, 12 Jan 2026 17:19:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37734 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 12 Jan 2026 17:19:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 66206e00de17 - stable/14 - linuxkpi: Correct kstrtobool List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 66206e00de17f929a863f92c11cbb2938796beed Auto-Submitted: auto-generated Date: Mon, 12 Jan 2026 17:19:28 +0000 Message-Id: <69652d20.37734.654ae815@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=66206e00de17f929a863f92c11cbb2938796beed commit 66206e00de17f929a863f92c11cbb2938796beed Author: Dag-Erling Smørgrav AuthorDate: 2026-01-03 09:09:41 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-01-11 02:30:31 +0000 linuxkpi: Correct kstrtobool Implement the exact same logic as in Linux: * Accept 'e', 't', 'y', '1', "on" for true. * Accept 'd', 'f', 'n', '0', "of" for false. * Disregard any characters beyond that. * Check that the string is not null, but don't check the result pointer. MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: bz, emaste Differential Revision: https://reviews.freebsd.org/D54451 (cherry picked from commit f86148d2777d4d7985ed8f4ae957c41c44bd2484) --- sys/compat/linuxkpi/common/include/linux/kstrtox.h | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/linux/kstrtox.h b/sys/compat/linuxkpi/common/include/linux/kstrtox.h index 6a145c409038..05bf94dd375d 100644 --- a/sys/compat/linuxkpi/common/include/linux/kstrtox.h +++ b/sys/compat/linuxkpi/common/include/linux/kstrtox.h @@ -249,22 +249,16 @@ kstrtoull(const char *cp, unsigned int base, unsigned long long *res) static inline int kstrtobool(const char *s, bool *res) { - size_t len; - - if (s == NULL || (len = strlen(s)) == 0 || res == NULL) + if (s == NULL || *s == '\0') return (-EINVAL); - /* skip newline character, if any */ - if (s[len - 1] == '\n') - len--; - - if (len == 1 && strchr("yY1", s[0]) != NULL) + if (strchr("eEtTyY1", s[0]) != NULL) *res = true; - else if (len == 1 && strchr("nN0", s[0]) != NULL) + else if (strchr("dDfFnN0", s[0]) != NULL) *res = false; - else if (strncasecmp("on", s, len) == 0) + else if (strncasecmp("on", s, 2) == 0) *res = true; - else if (strncasecmp("off", s, len) == 0) + else if (strncasecmp("of", s, 2) == 0) *res = false; else return (-EINVAL);