Date: Sun, 1 Apr 2012 12:18:12 +0100 From: Chris Rees <utisoft@gmail.com> To: Ruslan Mahmatkhanov <cvs-src@yandex.ru> Cc: FreeBSD Ports Mailing List <ports@freebsd.org> Subject: Re: Preferred way of applying OSVERSION-dependend patches Message-ID: <CADLo8387cVyxDS0w%2BNV420hbxmnTnpe8pn5sWUQrssrxgqpcWg@mail.gmail.com> In-Reply-To: <4F7827A7.3030804@yandex.ru> References: <4F7827A7.3030804@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 Apr 2012 11:03, "Ruslan Mahmatkhanov" <cvs-src@yandex.ru> wrote:
>
>
> Good day!
>
> What is a preferred way of doing subj?
>
> 1. Add an extra-patch-* to files/ subdirectory and apply it depending
> of checks in Makefile (.if ${OSVERSION}).
> 2. Add an patch-* to files subdirectory that applies unconditionally
> and that checking for __FreeBSD_version in app code itself.
>
> The second one will guarantee that the patch still applies cleanly on
port versions update, but it will make it more hard to find conditional
checks for obsoleted FreeBSD versions (because most people, I believe, only
looking to Makefile for things like this).
>
Definitely 2 :)
Always testing beats sometimes testing.
Stick a comment in the Makefile that a reasonable regexp will match.
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo8387cVyxDS0w%2BNV420hbxmnTnpe8pn5sWUQrssrxgqpcWg>