From owner-cvs-all Mon Mar 25 11:32:10 2002 Delivered-To: cvs-all@freebsd.org Received: from mail17.speakeasy.net (mail17.speakeasy.net [216.254.0.217]) by hub.freebsd.org (Postfix) with ESMTP id 751A237B41A for ; Mon, 25 Mar 2002 11:31:50 -0800 (PST) Received: (qmail 2851 invoked from network); 25 Mar 2002 19:31:49 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail17.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 25 Mar 2002 19:31:49 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g2PJWTv83284; Mon, 25 Mar 2002 14:32:29 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200203230139.g2N1d7X88732@freefall.freebsd.org> Date: Mon, 25 Mar 2002 14:31:51 -0500 (EST) From: John Baldwin To: dillon@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_prot.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23-Mar-2002 dillon@FreeBSD.org wrote: > Is there a reason you made this commit without : > > (1) notifying me and Err, I was not aware that you wished for explicit notification. > (2) not resolving the giant wrappers issue first. I attempted to do this by working on an instrumentation patch that would compromise by allowing the instrumentation code I don't really agree with to be in place while still preserving the final code flow of the syscalls, but since you demonstrated zero openness to compromise I gave up on it and figured there was no reason to waste my time further. > And, in fact, my commit would also have gotten getresuid() > and getresgid() out from under Giant, which your commit hasn't > done. Hmm, I missed merging those changes in. I'll fix that when I do the suser() API change. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message