From owner-svn-src-stable@freebsd.org Mon Mar 26 22:04:57 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 202F7F6F816; Mon, 26 Mar 2018 22:04:57 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 88A8076EC2; Mon, 26 Mar 2018 22:04:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id BAAB310A8BA; Mon, 26 Mar 2018 18:04:55 -0400 (EDT) From: John Baldwin To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r331591 - stable/11/sys/dev/mlx5/mlx5_core Date: Mon, 26 Mar 2018 15:04:49 -0700 Message-ID: <8910480.84UKvZQndd@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201803262106.w2QL6Ngg037236@repo.freebsd.org> References: <201803262106.w2QL6Ngg037236@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 26 Mar 2018 18:04:55 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2018 22:04:57 -0000 On Monday, March 26, 2018 09:06:23 PM Hans Petter Selasky wrote: > Author: hselasky > Date: Mon Mar 26 21:06:23 2018 > New Revision: 331591 > URL: https://svnweb.freebsd.org/changeset/base/331591 > > Log: > MFC r330660: > Add call to setup firmware data dump structure during device load in > mlx5core. > > Do not consider the inability to create a firmware dump fatal, but > inform about the situation and allow the driver to attach. The device > might not implement the needed VSC, or we might not know the layout of > the registers map. In either case, only firmware dump functionality is > limited, the network operations should be fine. > > Submitted by: kib@ > Sponsored by: Mellanox Technologies Please batch up MFC commits at least enough to ensure they compile. We really should not be breaking the build on stable branches. If you are merging a commit that required followup fixes in head, the MFC needs to include those followup fixes. I'm getting this failure on a tree at this revision: /usr/src/usr.sbin/mlx5tool/mlx5tool.c:31:10: fatal error: 'dev/mlx5/mlx5io.h' file not found #include ^~~~~~~~~~~~~~~~~~~ 1 error generated. --- mlx5tool.o --- *** [mlx5tool.o] Error code 1 See also: https://ci.freebsd.org/job/FreeBSD-stable-11-amd64-build/2930/console -- John Baldwin