From owner-freebsd-current@FreeBSD.ORG Fri Apr 2 07:20:14 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5F82F106564A for ; Fri, 2 Apr 2010 07:20:14 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.24]) by mx1.freebsd.org (Postfix) with ESMTP id 12F358FC14 for ; Fri, 2 Apr 2010 07:20:13 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 3so637951qwe.7 for ; Fri, 02 Apr 2010 00:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=lF85M8ydz05fN131jFLp74/vx7wivYtI/ac9EZVqYdo=; b=ghjTR48+2reEscYtWks5KSkkF1x17Wp1YbBtclSnKBIL89UpK24Pd2szERskYuNoVD sjcAO48soEApUa4jCgA04+MNvajcQ0jLy2LY7qoCpFes76y3tthDJRSTVMpSun9xIvt1 FNcaS/C75HCnnBEvSIYnxNF+YfA+Ox9Hg2f6E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=AO1oRX0Qo4k58R7KNFQSBwP9qeJVu6tZOjfRVJlaKYwHH2NCiNgPFhd4AEUobeuAKG gNSPr+8Sf3YtX7fprRa6/B+ca1GUwFzp/6nYe7WGOWBUW+lItgYC2Nb5fgoLi5Y/4MDi 5vwpenKZB/AmBdD9dTsdMCQvg+ZdYziTTpB08= MIME-Version: 1.0 Received: by 10.229.33.72 with HTTP; Fri, 2 Apr 2010 00:20:12 -0700 (PDT) In-Reply-To: References: <4BA7E0B8.3080406@delphij.net> <4BAE2B4F.6060005@protected-networks.net> <4BB3FD5D.9070600@uffner.com> <4BB4FB35.2040703@uffner.com> Date: Fri, 2 Apr 2010 00:20:12 -0700 Received: by 10.229.221.78 with SMTP id ib14mr3119239qcb.28.1270192812805; Fri, 02 Apr 2010 00:20:12 -0700 (PDT) Message-ID: From: Garrett Cooper To: Xin LI Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: HEADSUP: zlib updated [svn commit: r205471 - in head: . lib/libz lib/libz/contrib lib/libz/doc sys/sys] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 07:20:14 -0000 On Thu, Apr 1, 2010 at 9:30 PM, Xin LI wrote: > Hi, Tom, > > On Thu, Apr 1, 2010 at 12:59 PM, Tom Uffner wrote: > [...] >> i realize this. i was just adding to the list of ports that no longer >> build after this change. ghostscript is kind of important for print >> support. >> >> i doubt this is "right" either, but it is a quick & dirty way to >> make mplayer compile again: >> >> --- configure.orig =A0 =A0 =A02010-04-01 15:49:37.000000000 -0400 >> +++ configure =A0 2010-04-01 15:50:50.000000000 -0400 >> @@ -5337,7 +5337,7 @@ >> =A0#include >> =A0int main(void) { return 0; } >> =A0EOF >> - =A0 =A0cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 >> -D_LARGEFILE64_SOURCE \ >> + =A0 =A0cc_check -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 \ >> =A0 =A0 =A0 -ldvdread $_ld_dl && _dvdread=3Dyes && _res_comment=3D"exter= nal" >> =A0 fi >> =A0fi >> @@ -7412,8 +7412,6 @@ >> =A0if test "$_largefiles" =3D yes || freebsd ; then >> =A0 CFLAGS=3D"$CFLAGS -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64" >> =A0 if test "$_dvdread" =3D yes || test "$_libdvdcss_internal" =3D yes ;= then >> - =A0 =A0# dvdread support requires this (for off64_t) >> - =A0 =A0CFLAGS=3D"$CFLAGS -D_LARGEFILE64_SOURCE" >> =A0 =A0 cygwin && CFLAGS=3D"$CFLAGS -DSYS_CYGWIN" >> =A0 fi >> =A0fi > > Specifying -DFOO basically means in C code one have: > > %%% > #define FOO 1 > %%% Actually, `CFLAGS +=3D -DFOO=3D1' is different from `CFLAGS +=3D -DFOO' (I think Xin Li meant to state the former format). $ for i in -DBAR -DFOO -DFOO=3D1 -DFOO=3D2; do echo "$i"; cc -c $i test_defined.c; done -DBAR -DFOO test_defined.c:2:2: warning: #warning FOO is defined test_defined.c:6:2: warning: #warning FOO is 1 test_defined.c:10:2: warning: #warning FOO is non-zero -DFOO=3D1 test_defined.c:2:2: warning: #warning FOO is defined test_defined.c:6:2: warning: #warning FOO is 1 test_defined.c:10:2: warning: #warning FOO is non-zero -DFOO=3D2 test_defined.c:2:2: warning: #warning FOO is defined test_defined.c:10:2: warning: #warning FOO is non-zero $ cat test_defined.c #ifdef FOO #warning FOO is defined #endif #if FOO =3D=3D 1 #warning FOO is 1 #endif #if FOO #warning FOO is non-zero #endif [...] Thanks, -Garrett