From owner-svn-src-head@FreeBSD.ORG  Tue Nov  5 05:32:06 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 9634A161;
 Tue,  5 Nov 2013 05:32:06 +0000 (UTC)
 (envelope-from jmg@h2.funkthat.com)
Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id C77AD2CC7;
 Tue,  5 Nov 2013 05:32:05 +0000 (UTC)
Received: from h2.funkthat.com (localhost [127.0.0.1])
 by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id rA55VwtB044597
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Mon, 4 Nov 2013 21:31:58 -0800 (PST)
 (envelope-from jmg@h2.funkthat.com)
Received: (from jmg@localhost)
 by h2.funkthat.com (8.14.3/8.14.3/Submit) id rA55Vwdk044596;
 Mon, 4 Nov 2013 21:31:58 -0800 (PST) (envelope-from jmg)
Date: Mon, 4 Nov 2013 21:31:58 -0800
From: John-Mark Gurney <jmg@funkthat.com>
To: Eitan Adler <eadler@FreeBSD.org>
Subject: Re: svn commit: r257646 - head/lib/libc/string
Message-ID: <20131105053158.GQ73243@funkthat.com>
References: <201311041905.rA4J5WT0097968@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201311041905.rA4J5WT0097968@svn.freebsd.org>
User-Agent: Mutt/1.4.2.3i
X-Operating-System: FreeBSD 7.2-RELEASE i386
X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88  9322 9CB1 8F74 6D3F A396
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger?
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2
 (h2.funkthat.com [127.0.0.1]); Mon, 04 Nov 2013 21:31:58 -0800 (PST)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Nov 2013 05:32:06 -0000

Eitan Adler wrote this message on Mon, Nov 04, 2013 at 19:05 +0000:
> Author: eadler
> Date: Mon Nov  4 19:05:31 2013
> New Revision: 257646
> URL: http://svnweb.freebsd.org/changeset/base/257646
> 
> Log:
>   Use OpenBSD's revamped description of strlcpy and strlcat.
>   
>   This explanation is supposed to be simpler and better.  In particular
>   "comparing it to the snprintf API provides lots of value, since it raises the
>   bar on understanding, so that programmers/auditors will a better job calling
>   all 3 of these functions."

Can we add a warning that it is not safe to just simply replace strncpy
with strlcpy?  strncpy does something useful in that it NULs out the
remaining buffer, which when coping strings from/to kernel buffers
prevent information leaks, so I'd argue that strlcpy can be used
incorrectly just as strncpy can be...

Just a thought...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."