From owner-freebsd-acpi@FreeBSD.ORG Fri Oct 12 23:58:06 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B6038E43; Fri, 12 Oct 2012 23:58:06 +0000 (UTC) (envelope-from villa.alberto@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id B1DD08FC12; Fri, 12 Oct 2012 23:58:05 +0000 (UTC) Received: by mail-bk0-f54.google.com with SMTP id jf20so1724961bkc.13 for ; Fri, 12 Oct 2012 16:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=Wo1xIGaulpteuNUG2BEJ82bPJHb0vq+ku6PcPQJBrfs=; b=bdcXqERnVIMUsxGHaB2xMKHeyJO0pyJLD6uJ8fHkcPB+eaF+AT5oH1UHZqVD8ulOgO WwVHx04I/nfEasltphiFDfIpuw4NvC87dWCmhlLj1Yq9+qyONtIbgvQuJr1OEOzEWum/ BxPvkF7bgXwr5sPofULc7bv03QQ+XHn3IlyaKzDjrnPz9Q2UsBfCQKhTrscHl7y5qyl6 4BC99BZNPqZ6YLdAyp7QFISuZP3S+DOtLPuxpjDBzHNtGZ9YEXWyMSuYryBY7WLLCduu aFkCktpD5LWrBBnSfe3PdxzQHU+ku9LbBGrKPwn9CIY+5exRybYdV6VrByR4rmItXWaG b3tA== Received: by 10.204.5.156 with SMTP id 28mr1659896bkv.86.1350086284481; Fri, 12 Oct 2012 16:58:04 -0700 (PDT) MIME-Version: 1.0 Sender: villa.alberto@gmail.com Received: by 10.204.227.144 with HTTP; Fri, 12 Oct 2012 16:57:43 -0700 (PDT) In-Reply-To: <201210121006.17276.jhb@freebsd.org> References: <20121005215316.GA38707@triton8.kn-bremen.de> <201210121006.17276.jhb@freebsd.org> From: Alberto Villa Date: Sat, 13 Oct 2012 01:57:43 +0200 X-Google-Sender-Auth: L3MEVWOp24tPaGFuZWV1xAl3ZG4 Message-ID: Subject: Re: Dell acpi_video patch To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Cc: acpi@freebsd.org, freebsd-acpi@freebsd.org, Juergen Lock , mobile@freebsd.org X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2012 23:58:06 -0000 On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin wrote: > I think this is correct, but in we need to do more to properly handle that > flag (DOD_DEVID_SCHEME_STD). Specifically, we shouldn't trust any bits in the > device ID unless that bit is set (except for the special case of > DOD_DEVID_LCD) as per my reading of the _DOD description in the ACPI 3.0b > spec. I think this larger patch will do that while also fixing your case: I tested your patch and the only effect is that my three reported screens (I'm on a laptop) changed from "crt" to "out" (I understand why, from the code): hw.acpi.video.out0.active: 1 hw.acpi.video.out1.active: 1 hw.acpi.video.out1.brightness: 100 hw.acpi.video.out1.fullpower: 100 hw.acpi.video.out1.economy: 50 hw.acpi.video.out1.levels: 100 50 0 10 20 30 40 50 60 70 80 90 100 hw.acpi.video.out2.active: 1 Is there something I can do to help you make them recognised correctly, or is it fault of a buggy ACPI table? -- Alberto Villa, FreeBSD committer http://people.FreeBSD.org/~avilla