From owner-cvs-src@FreeBSD.ORG Tue May 25 23:42:10 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 011CA16A4CE; Tue, 25 May 2004 23:42:10 -0700 (PDT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 32D8C43D1F; Tue, 25 May 2004 23:42:09 -0700 (PDT) (envelope-from glebius@cell.sick.ru) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.9/8.12.8) with ESMTP id i4Q6fqvw025047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 26 May 2004 10:41:53 +0400 (MSD) (envelope-from glebius@cell.sick.ru) Received: (from glebius@localhost) by cell.sick.ru (8.12.9/8.12.6/Submit) id i4Q6fquN025046; Wed, 26 May 2004 10:41:52 +0400 (MSD) Date: Wed, 26 May 2004 10:41:52 +0400 From: Gleb Smirnoff To: Yar Tikhiy Message-ID: <20040526064152.GD24738@cell.sick.ru> References: <200405251449.i4PEnkIa098672@repoman.freebsd.org> <20040525164251.GA3245@ip.net.ua> <20040525173458.GA18554@comp.chem.msu.su> <20040525184757.GA5546@ip.net.ua> <20040526032055.GA42697@comp.chem.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20040526032055.GA42697@comp.chem.msu.su> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Ruslan Ermilov cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c if_fxpvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 May 2004 06:42:10 -0000 Dear sirs, may I insert some comments? On Wed, May 26, 2004 at 07:20:55AM +0400, Yar Tikhiy wrote: Y> ng_vlan(4) could send a control command to ng_ether(4) instructing Y> the latter to increment the VLAN counter on the Ethernet interface Y> and toggle VLAN_MTU on if the counter value became equal to 1. Two comments: 1) Just note that it should increment VLAN counter on creating of any new VLAN hook. 2) There may be some itermediate nodes between ng_ether and ng_vlan, e.g. ng_tee(4), ng_etf(4), any custom traffic shaping or accounting node. Two deal with second issue some new mechanism should be introduced in netgraph, e.g. "broadcast" messages, which go down a hook spreading across all nodes, and only nodes with appropriate cookie will see this message delivered. Y> Another way I see is to drop automatic fiddling with VLAN_MTU in Y> the first place and implement an option for ifconfig(8) so that a Y> user/admin can control the capability WRT a particular case, e.g., Y> disable it if a NIC displays erroneous behaviour in long frame mode. >From my point of view this is a good idea. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE