From owner-freebsd-current@FreeBSD.ORG Wed Mar 2 02:28:54 2011 Return-Path: Delivered-To: current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1233) id A0996106566B; Wed, 2 Mar 2011 02:28:54 +0000 (UTC) Date: Wed, 2 Mar 2011 02:28:54 +0000 From: Alexander Best To: Roman Divacky Message-ID: <20110302022854.GA42880@freebsd.org> References: <20110228203928.GA93494@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110228203928.GA93494@freebsd.org> Cc: current@freebsd.org Subject: Re: [TESTING]: boot2 changes X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2011 02:28:54 -0000 On Mon Feb 28 11, Roman Divacky wrote: > hi there, > > I have a patch that shrinks boot2 some: > > 1) it switches kname to be just a pointer instead of an array > thus avoiding a couple of memcpy()s > > 2) it changes ioctl to unsigned from uint8_t > > 3) it changes the first keyhit limit to 5 seconds from 3 > so that constant propagation can take place > > 4) it changes the ticks overflow computation as suggested by bde@ > > 5) it removes bi_basemem/bi_extmem/bi_memsizes_valid setting from > bootinfo as it is unused > > > the patch: > > http://lev.vlakno.cz/~rdivacky/boot2-almost-there-diet.patch > > It works for me and I'd like you to review/test this patch did you also take a look at the code in sys/boot/i386/common? many functions in sys/boot/i386/boot2/boot2.c are also defined there and some seem to contain improved code. e.g. was the return type of xputc() changed from int to void, i think that's quite a resonable change and might reduce the boot2 binary size further. cheers. alex > > thank you! > > roman -- a13x