From owner-freebsd-bugs@freebsd.org Wed Feb 21 20:48:44 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C3E6F29031 for ; Wed, 21 Feb 2018 20:48:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B1D2B72124 for ; Wed, 21 Feb 2018 20:48:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 19FA910937 for ; Wed, 21 Feb 2018 20:48:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w1LKmggP084530 for ; Wed, 21 Feb 2018 20:48:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w1LKmgYP084529 for freebsd-bugs@FreeBSD.org; Wed, 21 Feb 2018 20:48:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 226096] [zfs] zpool add attach internal error: out of memory, pool with many vdevs, since r324255 Date: Wed, 21 Feb 2018 20:48:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ea@uoga.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 20:48:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226096 Bug ID: 226096 Summary: [zfs] zpool add attach internal error: out of memory, pool with many vdevs, since r324255 Product: Base System Version: 11.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: ea@uoga.net Created attachment 190872 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D190872&action= =3Dedit init errno =3D 0; in zpool_read_labelr() On FreeBSD stable 11.1, any rev. since r324255, zpool add (or attach) may f= ail with "internal error: out of memory". I can reproduce this on a pool with m= any real physical disks, after adding 22-23 3x mirror vdevs, next one fails. Can not reproduce this on virtual configuration with simulated file based vdevs= . On a running pool with many mirror vdevs a "zpool detach" followed by "zpool attach" would also fail with the same error. I traced it back to svn commit r324255, on systems before this commit zpool= add attach works without failure, same hardware, I used beadm to boot different revisions. A quick fix that seems to work is to do "zpool create temporarypool daXX && zpool destroy temporarypool" then try again, i.e. "zpool attach bigtank daYY daXX". Attached here small patch that initializes "errno =3D 0" in zpool_read_labe= l(), tested on latest r329700. --=20 You are receiving this mail because: You are the assignee for the bug.=