From owner-cvs-user Fri Oct 20 11:18:50 1995 Return-Path: owner-cvs-user Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id LAA14823 for cvs-user-outgoing; Fri, 20 Oct 1995 11:18:50 -0700 Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6]) by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id LAA14816 ; Fri, 20 Oct 1995 11:18:34 -0700 Received: by sequent.kiae.su id AA09864 (5.65.kiae-2 ); Fri, 20 Oct 1995 21:56:45 +0400 Received: by sequent.KIAE.su (UUMAIL/2.0); Fri, 20 Oct 95 21:56:45 +0300 Received: (from ache@localhost) by ache.dialup.demos.ru (8.6.11/8.6.9) id UAA00941; Fri, 20 Oct 1995 20:55:51 +0300 To: "Andrey A. Chernov" , "Justin T. Gibbs" Cc: CVS-commiters@freefall.freebsd.org, cvs-user@freefall.freebsd.org References: <199510201723.KAA09542@aslan.cdrom.com> In-Reply-To: <199510201723.KAA09542@aslan.cdrom.com>; from "Justin T. Gibbs" at Fri, 20 Oct 1995 10:23:24 -0700 Message-Id: Organization: Olahm Ha-Yetzirah Date: Fri, 20 Oct 1995 20:55:50 +0300 (MSK) X-Mailer: Mail/@ [v2.40 FreeBSD] From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) X-Class: Fast Subject: Re: cvs commit: src/secure/libexec/telnetd sys_term.c Lines: 26 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 1126 Sender: owner-cvs-user@FreeBSD.org Precedence: bulk In message <199510201723.KAA09542@aslan.cdrom.com> Justin T. Gibbs writes: >>ache 95/10/20 10:16:59 >> >> Modified: secure/libexec/telnetd sys_term.c >> Log: >> Don't allow LD_* env. variables to be tricked >> Submitted by: Sam Hartman >I think that it should *only* exclude the variables that cause >the vulnerability. Just because I choose to use a variable >called LD_MY_TERMINAL_IS_BLUE doesn't mean I should get burned. Probably. But... There is too many LD_* variables in our ld, also some of them are unimplemented, they may be implemented in future or new LD_* variables can be added (in honor of Solaris style as I see). Better is not track ld changes here and refuse all LD_* variables at once. BTW, I don't know any pgm != ld which use something like LD_* for internal purposes. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - http://dt.demos.su/~ache : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849