From owner-svn-ports-head@FreeBSD.ORG Thu Jan 30 12:47:53 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F0796417 for ; Thu, 30 Jan 2014 12:47:53 +0000 (UTC) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 57DD417D3 for ; Thu, 30 Jan 2014 12:47:52 +0000 (UTC) Received: (qmail 64496 invoked by uid 89); 30 Jan 2014 12:47:51 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@88.217.181.240) by mail.grem.de with ESMTPA; 30 Jan 2014 12:47:51 -0000 Date: Thu, 30 Jan 2014 13:47:50 +0100 From: Michael Gmelin To: Tijl Coosemans Subject: Re: svn commit: r341775 - in head: Mk/Uses converters/libiconv devel/gettext Message-ID: <20140130134750.645223a2@bsd64.grem.de> In-Reply-To: <20140130132652.5d945d44@kalimero.tijl.coosemans.org> References: <201401292024.s0TKOomF031237@svn.freebsd.org> <52E97640.5020703@freebsd.org> <52EA297E.6030607@kovesdan.org> <20140130132652.5d945d44@kalimero.tijl.coosemans.org> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.18; amd64-portbld-freebsd9.1) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: =?UTF-8?B?R8OhYm9yIEvDtnZlc2TDoW4=?= , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Andrey Chernov , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2014 12:47:54 -0000 On Thu, 30 Jan 2014 13:26:52 +0100 Tijl Coosemans wrote: > On Thu, 30 Jan 2014 11:29:18 +0100 G=C3=A1bor K=C3=B6vesd=C3=A1n wrote: > > On 2014.01.29. 22:44, Andrey Chernov wrote: > >> On 30.01.2014 0:24, Tijl Coosemans wrote: > >>>> - Add two new arguments to USES=3Diconv so ports can indicate > >>>> they use GNU iconv extensions that the base system iconv doesn't > >>>> support yet: > >>>> * wchar_t: port uses the special WCHAR_T character > >>>> conversion. > >>>> * translit: port uses //TRANSLIT or //IGNORE conversion > >>>> options. Adding one or both of these arguments makes the port > >>>> depend on converters/libiconv for now. > >>>> - Allow installation of converters/libiconv on FreeBSD 10+. > >> Delete-restore loop. > >> What people smoke, replacing gnu iconv with system one without even > >> implementing //TRANSLIT and //IGNORE first? > >> At this stage looks more logical to implement them in the system > >> iconv, rather than to return gnu one back. >=20 > That's not an option for users on 10.0 release. >=20 > > In fact, system iconv uses //TRANSLIT by default. What it does not=20 > > implement is the lack of //TRANSLIT. This is conformant to POSIX. >=20 > I see. I don't think we have to implement the lack of //TRANSLIT. > What we do need are //IGNORE and WCHAR_T. Also, the transliteration > is different. The example code I was given prints the unicode > character "=C5=BD": >=20 > # cat test.php > print iconv("UTF-8", "ISO-8859-1//TRANSLIT", "\xc5\xbd"); > ?> > # php test.php > Z >=20 > With system iconv this prints "?" and with libiconv "Z". "?" is not a useful transliteration for real world applications (e.g. convert a name, so it can be printed in US-ASCII - required by many legacy systems like credit card networks). It's obviously much easier to implement "transliterate everything to ?", but almost certainly not what people using //TRANSLIT expect to happen. FreeBSD had been using GNU iconv forever and so far I haven't seen anything in 10.0-RELEASE ports/UPDATING, release ERRATA etc. that would keep people from silently breaking applications on update. In my opinion that would be the bare minimum measure when doing such a change. PHP Example (before the patch to use GNU iconv, thanks again for your work): With gnu iconv: # php t.php Gabor Kovesdan With system iconv: # php t.php Gbor Kvesdn --=20 Michael Gmelin