From owner-freebsd-net Sat Oct 12 19:22:27 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE00037B401 for ; Sat, 12 Oct 2002 19:22:26 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 416D743E9E for ; Sat, 12 Oct 2002 19:22:26 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.3/8.12.3) with ESMTP id g9D2MPpk010016; Sat, 12 Oct 2002 20:22:25 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 12 Oct 2002 20:22:03 -0600 (MDT) Message-Id: <20021012.202203.58451922.imp@bsdimp.com> To: rizzo@icir.org Cc: net@FreeBSD.ORG Subject: Re: Comments Please From: "M. Warner Losh" In-Reply-To: <20021012191709.B93684@carp.icir.org> References: <20021012171339.A92744@carp.icir.org> <20021012.200747.59843102.imp@bsdimp.com> <20021012191709.B93684@carp.icir.org> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org In message: <20021012191709.B93684@carp.icir.org> Luigi Rizzo writes: : On Sat, Oct 12, 2002 at 08:07:47PM -0600, M. Warner Losh wrote: : ... : > : reveals the use of an explicit constant (6) in net/if_arp.h and : > : netinet/if_ether.c; there is more of the same in net/bridge.c : > : (my fault), net/if_atmsubr.c, netinet/if_ether.c, netncp/ncp_subr.c : > : > atmsubr? Doesn't ATM have its own constants? : : eh, that's the problem with explicit constants, you can never tell : whether "6" is english, german or italian... in any case the : relevant piece of code is: : : net/if_atmsubr.c: if (bcmp(alc, ATMLLC_HDR, 6)) { : : I have no idea if it has any relation with ethernet header sizes. Looks like that one should be something else, since it is an atm llc header. Of course the atm code should be using if_llc.h to get this stuff, but that's another story... Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message