From owner-freebsd-hackers Fri Mar 1 9:51:17 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from outboundx.mv.meer.net (outboundx.mv.meer.net [209.157.152.12]) by hub.freebsd.org (Postfix) with ESMTP id 8CEA937B402 for ; Fri, 1 Mar 2002 09:51:10 -0800 (PST) Received: from meer.meer.net (mail.meer.net [209.157.152.14]) by outboundx.mv.meer.net (8.11.6/8.11.6) with ESMTP id g21Hp6s51471; Fri, 1 Mar 2002 09:51:06 -0800 (PST) (envelope-from gnn@neville-neil.com) Received: from neville-neil.com ([209.157.133.226]) by meer.meer.net (8.9.3/8.9.3/meer) with ESMTP id JAA1797377; Fri, 1 Mar 2002 09:49:54 -0800 (PST) Message-Id: <200203011749.JAA1797377@meer.meer.net> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Luigi Rizzo Cc: Bob Bishop , Doug Ambrisko , hackers@FreeBSD.ORG Subject: Re: Multicast problem with sis interface? In-Reply-To: Message from Luigi Rizzo of "Fri, 01 Mar 2002 03:56:23 PST." <20020301035623.A32974@iguana.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 01 Mar 2002 09:49:50 -0800 From: "George V. Neville-Neil" Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > I find this hard to believe. The "sis" driver does the padding > itself, using ones for the padding. I have verified this locally. > And a switch which receives a short packet (runt packet) is > not supposed to pass it through. I have verified this as well, and did before I hacked that patch together. > > ed, vr, rl > > ok, these three drivers behave as follows: > > "ed" pads with whatever is left in the transmit buffer from > earlier transmissions; > "vr" pads with whatever is available in the mbuf after the actual data; > "rl" pads with zeroes (in the driver) > and of course > "sis" pads in hardware (with ones) > I'm downloading the 802.3 spec now. Just to be sure. Of course I have no problem letting the driver stand as is if it's "right" but my memory, which I'm checking via the spec, is that short packets are to be padded with 0s. More when the darned things are done. BTW I've no attachment to putting this change in, I decided to check/fix this as a way of testing my new development environment. We can always close the PR, which is kern/35442. Later, George -- George V. Neville-Neil gnn@neville-neil.com NIC:GN82 "Those who would trade liberty for temporary security deserve neither" - Benjamin Franklin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message