From owner-cvs-all Thu Feb 5 13:37:22 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA01978 for cvs-all-outgoing; Thu, 5 Feb 1998 13:37:22 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from lsd.relcom.eu.net (root@lsd.relcom.eu.net [193.124.23.23]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA01967 for ; Thu, 5 Feb 1998 13:37:18 -0800 (PST) (envelope-from ache@lsd.relcom.eu.net) Received: (from ache@localhost) by lsd.relcom.eu.net (8.8.8/8.8.8) id XAA16084; Thu, 5 Feb 1998 23:55:47 +0300 (MSK) (envelope-from ache) Message-ID: <19980205235544.65532@nagual.pp.ru> Date: Thu, 5 Feb 1998 23:55:44 +0300 From: =?koi8-r?B?4c7E0sXKIP7F0s7P1w==?= To: Martin Cracauer , cvs-commiters@FreeBSD.ORG Subject: Re: Please review fix for /bin/sh SIGQUIT/SIGINT problem Mail-Followup-To: Martin Cracauer , cvs-commiters@FreeBSD.ORG References: <19980205202824.51394@cons.org> <19980205204320.31887@cons.org> <19980205213833.25257@cons.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89.1i In-Reply-To: <19980205213833.25257@cons.org>; from cracauer@cons.org on Thu, Feb 05, 1998 at 09:38:33PM +0100 Organization: Biomechanoid Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-To-Unsubscribe: mail to majordomo@FreeBSD.org "unsubscribe cvs-all" On Thu, Feb 05, 1998 at 09:38:33PM +0100, Martin Cracauer wrote: > + if (mode == FORK_FG) { > + oldsigquit = signal(SIGQUIT,SIG_IGN); > + oldsigint = signal(SIGINT,SIG_IGN); > + oldsigs_valid = 1; > + } > pid = fork(); > if (pid == -1) { > TRACE(("Fork failed, errno=%d\n", errno)); > *************** I not see you restore signals immediately after failed fork. BTW, it seems "return pid" must be added for pid == -1 case -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/