From owner-freebsd-arch Sun Feb 23 21:29:13 2003 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BEA9837B401 for ; Sun, 23 Feb 2003 21:29:11 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9B3943FB1 for ; Sun, 23 Feb 2003 21:29:10 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.7/8.12.2) with ESMTP id h1O5TA2p006082; Sun, 23 Feb 2003 21:29:10 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.7/8.12.7/Submit) id h1O5T9QB006081; Sun, 23 Feb 2003 21:29:09 -0800 (PST) Date: Sun, 23 Feb 2003 21:29:09 -0800 From: "David O'Brien" To: Marcel Moolenaar Cc: freebsd-arch@FreeBSD.ORG Subject: Re: [RFC] splitting of conf/NOTES Message-ID: <20030224052909.GA6020@dragon.nuxi.com> Reply-To: freebsd-arch@FreeBSD.ORG References: <20030224001644.GA67255@dragon.nuxi.com> <20030224120037.D4403-100000@gamplex.bde.org> <20030224023118.GD67312@dragon.nuxi.com> <20030224040250.GA19558@athlon.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030224040250.GA19558@athlon.pn.xcllnt.net> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Feb 23, 2003 at 08:02:50PM -0800, Marcel Moolenaar wrote: > \begin{snippet} > @@ -150,8 +150,13 @@ > u_int32_t target_address:12; > u_int32_t initiator_address:12; > u_int32_t function:8; > +#if defined(__alpha__) || defined(__sparc64__) > + u_int64_t initiator_context; > + u_int64_t transaction_context; > +#else > u_int32_t initiator_context; > u_int32_t transaction_context; > +#endif > u_int16_t detailed_status; > #define I2O_DETAIL_STATUS_SUCCESS 0x0000 > #define I2O_DETAIL_STATUS_BAD_KEY 0x0002 > \end{snippet} > > It makes sense in the above case to be able to test for __ILP32__ > or __LP64__ rather than listing all the 64-architectures. Needless > to say that the above code is broken on ia64 (irrespective whether > it could actually be used on ia64). On ia64, _LP64 and __LP64__ > are defined, but I don't know if that's true for all 64-bit > platforms that we support. This was only posted so people could play with the real goal of a LINT everywhere. Obivisouly the changes are totally bogus and sos needs to figure out the best way to handle this. This snippet I did so I could at least point out the problems to him. > \begin{snippet} > Index: sparc64/isa/isa_dma.c > =================================================================== > RCS file: sparc64/isa/isa_dma.c > diff -N sparc64/isa/isa_dma.c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ sparc64/isa/isa_dma.c 23 Feb 2003 23:12:42 -0000 > @@ -0,0 +1,105 @@ > \end{snippet} > > This file appears to be glue only. We really should get rid of > our isa/legacy infected MI code so that we don't have to pollute > new architectures with this. It is. Jake seems violently opposed to this. I wish we would come to an agreement that LINT should compile every piece of code, or just code that could reasonably be expected to work on said platform. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message