Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Jan 2020 04:41:26 +0000 (UTC)
From:      Conrad Meyer <cem@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r357244 - head/sys/dev/qlxgb
Message-ID:  <202001290441.00T4fQMR087695@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: cem
Date: Wed Jan 29 04:41:26 2020
New Revision: 357244
URL: https://svnweb.freebsd.org/changeset/base/357244

Log:
  qlxgb(4): Use defined evaluation order
  
  Reported by:	Coverity
  CID:		1193717

Modified:
  head/sys/dev/qlxgb/qla_os.c

Modified: head/sys/dev/qlxgb/qla_os.c
==============================================================================
--- head/sys/dev/qlxgb/qla_os.c	Wed Jan 29 04:33:45 2020	(r357243)
+++ head/sys/dev/qlxgb/qla_os.c	Wed Jan 29 04:41:26 2020	(r357244)
@@ -226,7 +226,7 @@ qla_watchdog(void *arg)
 			taskqueue_enqueue(ha->tx_tq, &ha->tx_task);
 		}
 	}
-	ha->watchdog_ticks = ha->watchdog_ticks++ % 1000;
+	ha->watchdog_ticks = (ha->watchdog_ticks + 1) % 1000;
 	callout_reset(&ha->tx_callout, QLA_WATCHDOG_CALLOUT_TICKS,
 		qla_watchdog, ha);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202001290441.00T4fQMR087695>