From owner-svn-ports-head@FreeBSD.ORG Sat May 4 12:26:28 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 1A7EB564; Sat, 4 May 2013 12:26:28 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x231.google.com (mail-wi0-x231.google.com [IPv6:2a00:1450:400c:c05::231]) by mx1.freebsd.org (Postfix) with ESMTP id 324D817BC; Sat, 4 May 2013 12:26:27 +0000 (UTC) Received: by mail-wi0-f177.google.com with SMTP id hq12so1346531wib.16 for ; Sat, 04 May 2013 05:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=bJkNjjWkGME+RCigogyIUz/Ni5RWSJFetyYKxS7SS7k=; b=kDvRVxnMCkNCoSXv6PFoEufZt+xU8GmwEOwIGgZFBMAMopoNWuS7hdcY1jFNOGFm59 rRaRG74AzMmkfv6LVrZ95C2xBvwHEqKkEMIsCvjFQ4lefJ3EGgf/vK7WuDtVRPfHEzyE qdVMiUlKDZMZ3Sv1zCS9QdwAZvsAYjY3rJLKKDHDloac+g0Va/5pQPIOmh1p7bgAsibf COQnEypXseVUW9FuQJGxlSqJgV/TVm5mE9AH7foO8P8wOwxRqPxTvSF6HBQl0c1LF277 TkvdNhrZnwknmtRSUBkLoXu7/PrIR8tkTfV6CRakz3nJVgxf0SgzSlIxKiEymsRjH9MZ c1lw== X-Received: by 10.180.13.179 with SMTP id i19mr1102110wic.18.1367650946619; Sat, 04 May 2013 00:02:26 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id k5sm1415448wiy.5.2013.05.04.00.02.25 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 04 May 2013 00:02:25 -0700 (PDT) Sender: Baptiste Daroussin Date: Sat, 4 May 2013 09:02:23 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r317243 - head/deskutils/menumaker Message-ID: <20130504070223.GV12114@ithaqua.etoilebsd.net> References: <201305032040.r43KeNIb027043@svn.freebsd.org> <20130504050636.GA54091@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="y5yQnZmVlpWlTeDv" Content-Disposition: inline In-Reply-To: <20130504050636.GA54091@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 May 2013 12:26:28 -0000 --y5yQnZmVlpWlTeDv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 04, 2013 at 05:06:36AM +0000, Alexey Dokuchaev wrote: > On Fri, May 03, 2013 at 08:40:23PM +0000, Baptiste Daroussin wrote: > > New Revision: 317243 > > URL: http://svnweb.freebsd.org/changeset/ports/317243 > >=20 > > Log: > > Fix build with bmake > >=20 > > @@ -14,6 +10,7 @@ MAINTAINER=3D ports@FreeBSD.org > > COMMENT=3D Menu generator for X Window Managers and desktop environmen= ts > > =20 > > USE_PYTHON=3D yes > > +USE_GMAKE=3D yes >=20 > Since you decided not to surround it with bmake-specific conditional this > time, I think it would be nice to add a comment instead, e.g.: >=20 > USE_GMAKE=3Dyes # fails with bmake(1) >=20 > I usually try to check periodically why some ports need gmake(1); it would > make it easier for me with such comments, thanks! I'll keep surrounding with test on .PARSEDIR then regards, Bapt --y5yQnZmVlpWlTeDv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlGEsn8ACgkQ8kTtMUmk6ExYFgCdEA6KwS4zc7LqPHtbOWZ+ISPc T6kAnj68euKTkRAbAelTluyRmpRukkm2 =/Prc -----END PGP SIGNATURE----- --y5yQnZmVlpWlTeDv--