From owner-freebsd-current  Sun Oct 15 18:23:53 2000
Delivered-To: freebsd-current@freebsd.org
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105])
	by hub.freebsd.org (Postfix) with ESMTP id EBC4937B503
	for <freebsd-current@FreeBSD.ORG>; Sun, 15 Oct 2000 18:23:49 -0700 (PDT)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.11.1/8.11.1) id e9G1TA321182;
	Sun, 15 Oct 2000 18:29:10 -0700 (PDT)
	(envelope-from sgk)
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
Message-Id: <200010160129.e9G1TA321182@troutmask.apl.washington.edu>
Subject: Re: more endian.h breakage; patch included.
In-Reply-To: <Pine.BSF.4.21.0010161137470.2121-100000@besplex.bde.org> from Bruce
 Evans at "Oct 16, 2000 11:44:20 am"
To: Bruce Evans <bde@zeta.org.au>
Date: Sun, 15 Oct 2000 18:29:10 -0700 (PDT)
Cc: freebsd-current@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL61 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Bruce Evans wrote:
> On Sun, 15 Oct 2000, Steven G. Kargl wrote:
> 
> > There is another patch needed in libdialog.
> 
> No patches are needed in applications; endian.h should be unbroken.
> 
> However, including endian.h directly seems to be a bug.  endian.h is not
> documented in any section 3 man page.  The documented interface is to
> include <sys/param.h>, although including <sys/types.h> is sufficient.
> 

Bruce,

Actually, in this case the endian.h change exposed a bug 
if the wait(2) manpage is correct.  In particular, <sys/types.h>
is required to occur before <sys/wait.h>, which was missing in
libdialog/prgbox.c and libc_r/uthread/uthread_wait4.c.

-- 
Steve


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message