From owner-freebsd-scsi Tue Oct 8 9:55:52 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 44C8537B401 for ; Tue, 8 Oct 2002 09:55:51 -0700 (PDT) Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A4D643E6A for ; Tue, 8 Oct 2002 09:55:50 -0700 (PDT) (envelope-from ken@panzer.kdm.org) Received: from panzer.kdm.org (localhost [127.0.0.1]) by panzer.kdm.org (8.12.5/8.12.5) with ESMTP id g98GtnKD034877; Tue, 8 Oct 2002 10:55:49 -0600 (MDT) (envelope-from ken@panzer.kdm.org) Received: (from ken@localhost) by panzer.kdm.org (8.12.5/8.12.5/Submit) id g98Gtncn034876; Tue, 8 Oct 2002 10:55:49 -0600 (MDT) (envelope-from ken) Date: Tue, 8 Oct 2002 10:55:49 -0600 From: "Kenneth D. Merry" To: "Moore, Eric Dean" Cc: freebsd-scsi@FreeBSD.ORG Subject: Re: CAM:READ-12 and WRITE-12 support Message-ID: <20021008105549.A34847@panzer.kdm.org> References: <0E3FA95632D6D047BA649F95DAB60E5701528EF0@EXA-ATLANTA.se.lsil.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E5701528EF0@EXA-ATLANTA.se.lsil.com>; from emoore@lsil.com on Tue, Oct 08, 2002 at 12:20:29PM -0400 Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Tue, Oct 08, 2002 at 12:20:29 -0400, Moore, Eric Dean wrote: > I'm concerned about 12 byte cdbs support in scsi_read_write() [source > /sys/cam/scsi/scsi_all.c]. > For 12 byte cdb's the block_count is being set in > scsi_ulto4b(block_count,scsi_cmd->length); > I think there might be a problem with the location of the length member in > structure scsi_rw_12. > > from [sys/cam/scsi/scsi-all.h] > > struct scsi_rw_12 > { > u_int8_t opcode; > u_int8_t byte2; > u_int8_t addr[4]; > u_int8_t reserved; > u_int8_t length[4]; > u_int8_t control; > }; > > According to SCSI-2 spec it should be > > struct scsi_rw_12 > { > u_int8_t opcode; > u_int8_t byte2; > u_int8_t addr[4]; > u_int8_t length[4]; > u_int8_t reserved; > u_int8_t control; > }; > > > * should the reserved field should be in bytes 7-10, instead of byte 8-11. Oops, you're right. Thanks for pointing that out! I'll fix it... Ken -- Kenneth Merry ken@kdm.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message