From owner-svn-src-head@FreeBSD.ORG  Tue Jan 24 15:15:28 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B9E5D106566B;
	Tue, 24 Jan 2012 15:15:28 +0000 (UTC) (envelope-from jh@FreeBSD.org)
Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi
	[195.197.172.115])
	by mx1.freebsd.org (Postfix) with ESMTP id 6953E8FC0A;
	Tue, 24 Jan 2012 15:15:28 +0000 (UTC)
Received: from jh (a91-153-115-208.elisa-laajakaista.fi [91.153.115.208])
	by gw01.mail.saunalahti.fi (Postfix) with SMTP id 5EACB15165C;
	Tue, 24 Jan 2012 17:15:21 +0200 (EET)
Date: Tue, 24 Jan 2012 17:15:20 +0200
From: Jaakko Heinonen <jh@FreeBSD.org>
To: Mikolaj Golub <trociny@freebsd.org>
Message-ID: <20120124151520.GA67038@jh>
References: <201201170125.q0H1PrlJ061058@svn.freebsd.org>
	<20120117171031.GA2316@a91-153-116-96.elisa-laajakaista.fi>
	<86obtvvr4v.fsf@kopusha.home.net>
	<20120122134218.GA2247@a91-153-116-96.elisa-laajakaista.fi>
	<86lioztzh5.fsf@kopusha.home.net>
	<20120123153457.GA2246@a91-153-116-96.elisa-laajakaista.fi>
	<86vco2yvrt.fsf@kopusha.home.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <86vco2yvrt.fsf@kopusha.home.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, Kevin Lo <kevlo@FreeBSD.org>,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r230252 - head/sys/fs/tmpfs
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jan 2012 15:15:28 -0000

On 2012-01-23, Mikolaj Golub wrote:
>  JH> Yes, the patch below does that. I suspect that flipping the MNT_RDONLY
>  JH> flag may be enough for tmpfs but I am not sure.
> 
> I see two issues with this patch:
> 
> 1) 'mount -u -o rw /mnt' does not upgrade to rw, although it returns success.

Argh, this is another nmount(2) bug. The update mount code automatically
sets the MNT_RDONLY flag but doesn't unset it. However the string option
always gets updated causing string options and flags to get out of sync.

Flags covered by MNT_UPDATEMASK are unset automatically.

> I think when remounting ro you should call vflush(), something like below:

Right.

Thanks for looking at the patch!

-- 
Jaakko