Date: Mon, 26 Apr 2010 00:59:02 -0700 From: Garrett Cooper <yanefbsd@gmail.com> To: Doug Barton <dougb@freebsd.org> Cc: freebsd-hackers@freebsd.org, Eitan Adler <eitanadlerlist@gmail.com>, "Aryeh M. Friedman" <aryeh.friedman@gmail.com>, Ruben de Groot <mail25@bzerk.org>, =?ISO-8859-1?Q?Trond_Endrest=F8l?= <Trond.Endrestol@fagskolen.gjovik.no> Subject: Re: regenerating /var/db/pkg Message-ID: <q2q7d6fde3d1004260059o8b545af7xa13c3a276af2b884@mail.gmail.com> In-Reply-To: <4BD5009C.20300@FreeBSD.org> References: <4BCE5ECC.6070202@gmail.com> <20100422111758.GA39338@ei.bzerk.org> <o2oa0777e081004220521sae3b1b06o884fd8eadffc6931@mail.gmail.com> <alpine.BSF.2.00.1004221610520.29574@mail.fig.ol.no> <p2oa0777e081004220908w775b40e7r86f0c978b1a05d1e@mail.gmail.com> <4BD07F2D.3030809@FreeBSD.org> <4BD07FCB.4030604@FreeBSD.org> <u2sa0777e081004221005ja2bca37ame13007df67898fcd@mail.gmail.com> <j2p7d6fde3d1004251944x8776db97z1482f6cb10e1ea64@mail.gmail.com> <4BD5009C.20300@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2010/4/25 Doug Barton <dougb@freebsd.org>: > On 04/25/10 19:44, Garrett Cooper wrote: >> On Thu, Apr 22, 2010 at 10:05 AM, Eitan Adler <eitanadlerlist@gmail.com>= wrote: >>> Same as before - if all is good I'll send a PR >>> >>> #!/bin/sh >>> # >>> # $FreeBSD: src/etc/periodic/daily/210.backup-aliases,v 1.6.36.1.2.1 >>> 2009/10/25 01:10:29 kensmith Exp $ >>> # >>> >>> # If there is a global system configuration file, suck it in. >>> # >>> if [ -r /etc/defaults/periodic.conf ] >>> then >>> =A0 =A0. /etc/defaults/periodic.conf >>> =A0 =A0source_periodic_confs >>> fi >>> >>> bak=3D/var/backups >>> db_loc=3D$(/usr/bin/make -f/usr/share/mk/bsd.port.mk -V PKG_DBDIR 2>/de= v/null) >>> bk_loc=3D"$bak/pkgdb.bak.tar.bz2" >>> >>> case "$daily_backup_pkgdb_enable" in >>> =A0 =A0[Yy][Ee][Ss]) >> >> This could be done via rc.subr's checkyesno function. > > It's periodic, not rc.d. =A0:) It would be nice if some of the more usable functions got moved out of rc.subr though :(... It would cure 20 lines of duplicate code here and elsewhere outside of rc land... >>> =A0 =A0 =A0 =A0if [ ! -d $db_loc ] >> >> Please quote the string. > > I generally do quote the string as a matter of paranoia, however the > practical result is likely to be the same. Yes, and you're assuming that users won't do: PKG_DBDIR :=3D /my /super /special/ directory with spaces Granted, a lot of things probably won't work that way, but just compounding to the issue of not quoting variables seems like a silly mistake to make :/. Thanks, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?q2q7d6fde3d1004260059o8b545af7xa13c3a276af2b884>