From nobody Tue Mar 3 17:59:59 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fQNr024WPz6TQv1 for ; Tue, 03 Mar 2026 18:00:16 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fQNqz52yVz3J7f for ; Tue, 03 Mar 2026 18:00:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-c6e248aa446so2384758a12.1 for ; Tue, 03 Mar 2026 10:00:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772560813; x=1773165613; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lCbKQM42v7TFsWMPcFYPr6Q/hgaMM/Ih0JJvHMyC77U=; b=Z2ihYzqDshgJ0FSLKzU8o6huIeXhGe/R4xYzQn1kZszrsjHRWGBjT/6IBr/eocIRnT VfrunqkgMTQb9brh44CB/85BzavYV/zvblT60zNtXPVHB/+Sid7GnT0PmMUs7jPQpvfJ xqxBaTxbyMbHqRMRsbO3sSecIgB6PZ1sgm3FPseuL9jfG+XLrNDo/wU8Wv6KB9PE/hSI aDqEumR82l57YOVsE6bd66aABnXiWvRLT9GoAuRZ158UgzHiLOaF86mif9bfkmRT9XVY Y+CQaPz1qcwrVWFLcabVPIR5FPVEjbKoq9riKQ172GG5ukzyjoHbyVpRpsA+GEyXYSvU 3BZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772560813; x=1773165613; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lCbKQM42v7TFsWMPcFYPr6Q/hgaMM/Ih0JJvHMyC77U=; b=ch1N42pWAKiXl7VfaCjTDup9Xb2tSHy6ZqWJi4ADLjQ73/Rg5xzgD3olX1i4q0KbYD TYM4k1Hw7lI4ATueGzDyFLAguAGS8dfwFPFf0BkV8QPJ/1NtVZTKw7a1q8DogcBpplOS YQABuBiKi22sr45TwzpoykCzNlurFFE0IE4s03BpoOqiL8DvRB2xf/JHd+/GqvQicVdS D1zQW9+ZX2kYqXYX3NaVgX+DmQCVDm639BmEtD92urSzolyZChJoa5z2Jv3frRxihTaG 04iF7XzYxHhG9F2mxJ7NdD0LqTtTrV/KdMoyzPq6mpgE404JEbXjtX8WtdzqkraQQg9T 4gGw== X-Forwarded-Encrypted: i=1; AJvYcCWvqGBbzb6yKKeFPRAn1PIiVRdGwtOynng7zZVKX41KGMqVAVwuz8XoVfScyy6Ee9rZR609f167e8WAPM6X7kJa2Ra3@freebsd.org X-Gm-Message-State: AOJu0Yz7hPtHDrVk4zn/EoveDhh0rVtce421hnL1EYtqnyHZ3OLHcTAw 6Ubm6KCO6Ti7BNmtsgbwz5U72tOvJ9FikR2M8HHu0lXnnaVZQ4UWh7s67pFvSihq X-Gm-Gg: ATEYQzwHcw6oZGb1il3vcLUttn+Y3CpqBXmtjr4DqYU9aCdXmfuanjVeBHfoj0+a61R Y3mcsEm6Fd+H0y5syQPXflAFmubYKCuw/7aDGAIOYLQg9nGvZVueGcrvmJnJcOci2Zn8KTweIyI JoznA0aVtkALLknMRjmk4PK4INi1ydYRpcs/GgyuUjzHOau1xEElG6X5VJFT9Fe3a0jM28qc2uP ncRE26zE7QvsNU/xogUhaGq72utVDJY0fz8YquYaIRFX9OV5/JgxXUHXjWxtXAeW0hcGq14U7/E cckq69tp1np+jaxFSxv8SaDgf4wpk7GKNtS1gLFUPr3R43+OPO+bnpCU7H5rqXCKDdRUKtaFPb2 2CXgX4GhHguoh+0wvhgWHxevGtkOPlKVgzxVqhFSFTCorJpp7wJRD3slX9SPLHYVBQInWk00G89 3e+HXdqAq9B7Rf4Pho8d+6Q2YMboZEujvX1i43kc2TKDwUYS3+l05k X-Received: by 2002:a17:903:390f:b0:2ae:478f:2ec with SMTP id d9443c01a7336-2ae478f12cfmr107569995ad.29.1772560812351; Tue, 03 Mar 2026 10:00:12 -0800 (PST) Received: from smtpclient.apple ([145.79.197.104]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae5e1699c9sm30763975ad.10.2026.03.03.10.00.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Mar 2026 10:00:11 -0800 (PST) Content-Type: multipart/signed; boundary="Apple-Mail=_1719D464-A3AF-4CFA-B3EB-46B72A91B06A"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.3\)) Subject: Re: git: bc9229035c5f - main - Allow programs run under this program to have arguments. From: "Enji Cooper (yaneurabeya)" In-Reply-To: <69a7162e.3e996.108a155f@gitrepo.freebsd.org> Date: Tue, 3 Mar 2026 09:59:59 -0800 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: References: <69a7162e.3e996.108a155f@gitrepo.freebsd.org> To: "George V. Neville-Neil" X-Mailer: Apple Mail (2.3826.700.81.1.3) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fQNqz52yVz3J7f X-Spamd-Bar: ---- --Apple-Mail=_1719D464-A3AF-4CFA-B3EB-46B72A91B06A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 3, 2026, at 9:11=E2=80=AFAM, George V. Neville-Neil = wrote: >=20 > The branch main has been updated by gnn: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dbc9229035c5f46674cf06b48d66e9f03= 9b3a9875 >=20 > commit bc9229035c5f46674cf06b48d66e9f039b3a9875 > Author: George V. Neville-Neil > AuthorDate: 2026-03-03 17:10:26 +0000 > Commit: George V. Neville-Neil > CommitDate: 2026-03-03 17:10:42 +0000 >=20 > Allow programs run under this program to have arguments. > --- > tools/test/hwpmc/pmctest.py | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) >=20 > diff --git a/tools/test/hwpmc/pmctest.py b/tools/test/hwpmc/pmctest.py > index ba20306f1d68..1c113c256e32 100755 > --- a/tools/test/hwpmc/pmctest.py > +++ b/tools/test/hwpmc/pmctest.py > @@ -27,6 +27,7 @@ import argparse > import tempfile > from pathlib import Path > import os > +import shlex >=20 > def gather_counters(): > """Run program and return output as array of lines.""" > @@ -58,7 +59,9 @@ def main(): > print("Choose one of --count OR --sample.") > sys.exit() >=20 > - program =3D Path(args.program).name > + # Split program and arguments properly > + program_parts =3D shlex.split(args.program) > + program =3D Path(program_parts[0]).name >=20 > if args.count =3D=3D True: > tmpdir =3D tempfile.mkdtemp(prefix=3Dprogram + "-", = suffix=3D"-counting-pmc") > @@ -73,8 +76,7 @@ def main(): > continue > if args.count =3D=3D True: > with open(tmpdir + "/" + program + "-" + counter + ".txt", = 'w') as file: > - p =3D subprocess.Popen(["pmcstat", > - "-p", counter, args.program], > + p =3D subprocess.Popen(["pmcstat", "-p", counter] + = program_parts, > text=3DTrue, stderr=3Dfile, = stdout=3Dfile) Hi George, The idiom that ruff recommends here is to use the unpacking = operator. For example, instead of doing: a =3D [] b =3D [] + a They recommend using: a =3D [] b =3D [*a] More about the rationale for this suggestion is discussed here: = https://docs.astral.sh/ruff/rules/collection-literal-concatenation/ . -Enji= --Apple-Mail=_1719D464-A3AF-4CFA-B3EB-46B72A91B06A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmnIZ8ACgkQGpE5DjPs NJjbXw//YybrvdsnUnxQDX7ec9+agmAmf/DtT7Zbao2pbYeQ3Z+DbfHUENlcrbz7 SXNxfpHlheq8UxFWyhy8h5fiioUOHkOBct9WI+u3xJmxq/zjl68GgIeDWnQvKdV9 mo9hFWzejW4nYk8ZblPvp9aTOpNq8NXrTzEOvj976qNHsAC/uHNjUiZi0IZM07+j aNJ98PERwrDF1QYw47nqRUuwaUfoSeydLfDYHue6XiI7DkksZzagQPYYHLqesSbo GAZuOqFzRR4VtKGAnrAbf6jqDaF4j7mgWOLp4+oRu3e0VUvngl9T5AItOre50Pgz jHFEKKOuMbhCm0Nnm6hqsfNCF9qc0b/N50EOgva4e/e82OYDiHB+vm4wqUXxcXJB 72U7b9qs4t2BejgMUbm3HM2xekK0f25Ku1WYGG1XzZGQkGIDCYuBH+WSkXW7XFDI Cy6wMd5cUT6TG/CDtYDXE2mG6V/I+39M35R4UVfySZFq63qpzUsXAmGxU5Yz3Bx2 TJnSGFYGv49NVfAjT6BmzSTtb6gFRfAlcfJk7rzqErgIkrYDW2y/q+LjBo2PTjBR KGFGWfZGmygfdmRkF34ZsVtyVPtuYEUEF8QqRVapS3kpxTDlMcQzsKP8PLRTzZLu qvf+Rro/IxTnNGSFYu167b1IwsUjsgZj04+mi8g3LTULgSuXmig= =xZhW -----END PGP SIGNATURE----- --Apple-Mail=_1719D464-A3AF-4CFA-B3EB-46B72A91B06A--