From owner-svn-src-head@FreeBSD.ORG  Tue Jan  5 06:02:53 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 60C851065670;
	Tue,  5 Jan 2010 06:02:53 +0000 (UTC)
	(envelope-from davidxu@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 17EA48FC15;
	Tue,  5 Jan 2010 06:02:53 +0000 (UTC)
Received: from apple.my.domain (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0562opM078456;
	Tue, 5 Jan 2010 06:02:51 GMT (envelope-from davidxu@freebsd.org)
Message-ID: <4B42D60A.1090901@freebsd.org>
Date: Tue, 05 Jan 2010 14:02:50 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Thunderbird 2.0.0.9 (X11/20080612)
MIME-Version: 1.0
To: Alexander Kabaev <kabaev@gmail.com>
References: <201001050339.o053dV1j075171@svn.freebsd.org>	<20100104233946.6d8bfa37@kan.dnsalias.net>	<4B42D07A.5000803@freebsd.org>
	<20100105005042.7fd9db85@kan.dnsalias.net>
In-Reply-To: <20100105005042.7fd9db85@kan.dnsalias.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r201547 - head/lib/libc/gen
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jan 2010 06:02:53 -0000

Alexander Kabaev wrote:
> On Tue, 05 Jan 2010 13:39:06 +0800
> David Xu <davidxu@freebsd.org> wrote:
> 
>> Alexander Kabaev wrote:
>>> Hi,
>>>
>>> some quick questions:
>>>
>>> FB10_COMPAT_PRIVATE is not used anywhere, why did it get committed?
>>> That aside, use of SYM_DEFAULT is pretty much always wrong.
>>>
>> Yes, this needs to be cleaned.
>>
>>> Also, does libthr really need to export sem_ symbols in 1.2
>>> namespace? I do not think so, but there might be reasons I am
>>> missing, could you shed some light here?
>>>
>> If libthr.so does not have 1.2 semaphore, a program linked against 
>> libthr may use 1.0 version at linking time, doesn't this cause
>> trouble? anyway, I am not symbol versioning expert, welcome to fix it.
>>
> 
> No, that won't happen. Compat (single '@') symbols are only resolvable
> at runtime, bit at link time, so ld won't see any sem_ symbols in libthr
> and by necessity will pick ones from libc.
> 
> 

My previous test got opposite result, it sticked with libthr, but this
time I tested it again, you are right, it uses version 1.2 from libc.
I will remove extra stubs from libthr.