From owner-svn-ports-head@freebsd.org Fri Mar 8 19:21:53 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 184281526AE4; Fri, 8 Mar 2019 19:21:53 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AB95B8835E; Fri, 8 Mar 2019 19:21:52 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 4E8193C475F; Fri, 8 Mar 2019 19:21:51 +0000 (UTC) Date: Fri, 8 Mar 2019 19:21:51 +0000 From: Brooks Davis To: Jan Beich Cc: Adam Weinberger , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r495007 - in head/devel: . llvm Message-ID: <20190308192151.GI78397@spindle.one-eyed-alien.net> References: <201903080040.x280ewF0084625@repo.freebsd.org> <20190308180601.GH78397@spindle.one-eyed-alien.net> <4l8d-9p4w-wny@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fCcDWlUEdh43YKr8" Content-Disposition: inline In-Reply-To: <4l8d-9p4w-wny@FreeBSD.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: AB95B8835E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.942,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 19:21:53 -0000 --fCcDWlUEdh43YKr8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 08, 2019 at 07:50:39PM +0100, Jan Beich wrote: > Brooks Davis writes: >=20 > > On Fri, Mar 08, 2019 at 06:03:55AM -0700, Adam Weinberger wrote: > > > >> On Thu, Mar 7, 2019 at 5:41 PM Brooks Davis wrote: > >> > > >> > It is intended for use by users and should not be a port build dep= endency. > >>=20 > >> Perhaps a comment near the top of the Makefile about this could be > >> helpful. Right now there's nothing in the Makefile or pkg-descr to > >> inform future porters of this important implementation detail. > > > > What I'd really like is a way to declare a port as ineligible to be a > > dependency. >=20 > Like the following? >=20 > $ DEVELOPER=3D1 make check-sanity > /!\ foo-0.1: Makefile errors /!\ >=20 > devel/llvm in BUILD_DEPENDS is unsupported, please use devel/llvm60 inste= ad >=20 > *** Error code 1 >=20 > Stop. > make: stopped in /usr/ports/misc/foo >=20 > --- Mk/bsd.sanity.mk.orig > +++ Mk/bsd.sanity.mk > @@ -70,6 +70,14 @@ DEV_WARNING+=3D "Not validating first entry in CATEGOR= IES due to being outside of > DEV_ERROR+=3D "USE_PERL5=3Dyes is unsupported, please use USES=3Dperl5 i= nstead" > .endif > =20 > +.if !empty(BUILD_DEPENDS:M*devel/llvm) > +DEV_ERROR+=3D "devel/llvm in BUILD_DEPENDS is unsupported, please use de= vel/llvm${LLVM_DEFAULT} instead" > +.endif > + > +.if !empty(BUILD_DEPENDS:M*lang/gcc) > +DEV_ERROR+=3D "lang/gcc in BUILD_DEPENDS is unsupported, please use USE_= GCC=3Dyes instead" > +.endif > + > .if !empty(LIB_DEPENDS:M*/../*) > DEV_ERROR+=3D "LIB_DEPENDS contains unsupported relative path to depende= ncy" > .endif >=20 I'd like something like: LEAF_PORT_BUILD=3D Ports should depend on explict devel/llvm## ports LEAF_PORT_LIB=3D Ports should depend on explict devel/llvm## ports -- Brooks --fCcDWlUEdh43YKr8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJcgsDOAAoJEKzQXbSebgfAUs0H+gPfJ71/8ISjtHEme17t59/g DetuwmuDb+uQH1NPYexYazcQA1FIlvX8YzWtTSTjwoq3N6gvnuiSN/ODIaWXGJb0 8qkZMrN4BFgpDgCrYLuC9OmffC2eMdVXroXUa1yh0lxfOKV/y2sQStWWW3GvEAeM pryVjp30tPxmybiowlwzm9tNrK5xmYSgvn1IwM74o4dReDsV2GBfUVemQ5MODi0e fLk2Eqdii18o3+Lixn8C3CmoBq9aZyRnbqOgizWczDC9kSVdR/EkAGnQusPfPnYM M5gr0N0TozJvnyBXOWuXa3XeI1x84HLm5fMDs5IfRyNu5APjvEIqhp6HEubFux0= =HMEW -----END PGP SIGNATURE----- --fCcDWlUEdh43YKr8--