From owner-freebsd-ports-bugs@freebsd.org Tue May 30 04:32:03 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1141AFBCA6 for ; Tue, 30 May 2017 04:32:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9E682775E3 for ; Tue, 30 May 2017 04:32:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v4U4W3f0071672 for ; Tue, 30 May 2017 04:32:03 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 219609] [NEW PORT] science/tensorflow: Computation using data flow graphs for scalable machine learning Date: Tue, 30 May 2017 04:32:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 May 2017 04:32:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219609 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch --- Comment #5 from Kubilay Kocak --- Initial review: 1) USES=3Dpython implies {RUN,BUILD}_DEPENDS on Python (can remove python:lang/python). Additionally, use of python:lang/python is always incorrect, as it only means 'depends on the `python` symlink' not 'depends = on python'. Only use USES=3Dpython: 2) Upstream stipulates Python 2.7 *and* 3.3+ support. USES=3Dpython:2.7 lim= its it to 2.7 only. 3) Regarding BROKEN (${OSVERSION} < 1100101): 3a) clang and llvm 3.8 exist in ports and can be depended on. If there is nothing intrinsic or super-complex preventing other versions of FreeBSD from building tensorflow, it should do so. 3b) If clang is not a requirement for building tensorflow, it should not be= a specific dependency. I see no mention of it on the 'building tensorflow from sources' document, but further, there *is* mention of builds with GCC, which motivates this comment. USES=3Dcompiler: should be used if a specific feature is required (See Porters Handbook -- USES -- compiler for details [1]) 4) Vendored dependencies should be extracted/removed and those ports/packag= es in the tree depended on instead. 5) It's unlikely that all python dependencies are both RUN and BUILD dependencies. Please make these as accurate to their actual dependency type= s as possible. 6) -march=3Dnative should not be used for CC/CFLAGS. Binary packages are bu= ilt from ports and build host CPU architecture has no bearing on end-user hardw= are, which may be different. 7) configuration (in this case ./configure) steps should be run in the do-configure target, not the build target. Additionally and ideally, using CONFIGURE_TARGET and other CONFIGURE_* variables, without requiring a custom do-configure target override. If bazel is a pre build or 'configuration' st= ep, it should be done in the configure target as well. 8) Patching of WRKSRC files should occur in {pre,post}-patch target, not bu= ild target. 9) Was using the port/package of pip tested rather than configuring/building the bundled tensorflow/tools/pip_package? The former should be used if and where possible. This port requires additional QA iterations [1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.htm= l#uses-compiler --=20 You are receiving this mail because: You are the assignee for the bug.=