From owner-freebsd-rc@FreeBSD.ORG  Thu Jun  1 11:35:34 2006
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@FreeBSD.org
Delivered-To: freebsd-rc@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4C3D516A4CF
	for <freebsd-rc@FreeBSD.org>; Thu,  1 Jun 2006 11:35:34 +0000 (UTC)
	(envelope-from flz@FreeBSD.org)
Received: from smtp.xbsd.org (xbsd.org [82.233.2.192])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C870443D45
	for <freebsd-rc@FreeBSD.org>; Thu,  1 Jun 2006 11:35:33 +0000 (GMT)
	(envelope-from flz@FreeBSD.org)
Received: from localhost (localhost.xbsd.org [127.0.0.1])
	by smtp.xbsd.org (Postfix) with ESMTP id DB51111A26
	for <freebsd-rc@FreeBSD.org>; Thu,  1 Jun 2006 13:35:32 +0200 (CEST)
Received: from smtp.xbsd.org ([127.0.0.1])
	by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new,
	port 10024) with ESMTP id 36187-02 for <freebsd-rc@FreeBSD.org>;
	Thu,  1 Jun 2006 13:35:18 +0200 (CEST)
Received: from mayday.esat.net (mayday.esat.net [193.95.134.156])
	by smtp.xbsd.org (Postfix) with ESMTP id AE6AE11A2F
	for <freebsd-rc@FreeBSD.org>; Thu,  1 Jun 2006 13:35:18 +0200 (CEST)
From: Florent Thoumie <flz@FreeBSD.org>
To: freebsd-rc@FreeBSD.org
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-HmqpF4p7JssWmYuhHtQH"
Date: Thu, 01 Jun 2006 12:35:17 +0100
Message-Id: <1149161717.29704.16.camel@mayday.esat.net>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.1 FreeBSD GNOME Team Port 
X-Virus-Scanned: amavisd-new at xbsd.org
Cc: 
Subject: Conventions for variables names in rc.d scripts
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jun 2006 11:35:35 -0000


--=-HmqpF4p7JssWmYuhHtQH
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

I'd like to make the following changes in rc.d scripts.

- Make all script-local all variable names begin with the "_${name}_"
prefix.
- Make all functions-local variable names begin with the "_" prefix and
use the "local" keyword.

This would avoid potential collision with rc.conf variables and other
variables defined in rc.subr or network.subr that aren't declared local.

Later I'd like to use the "local" keyword as much as possible in rc.subr
and network.subr.

Are there strong objections against these changes?

On a different matter, I've noticed that some of our scripts have
"#!/bin/sh -" shebang line instead of "#!/bin/sh" and just couldn't find
a good reason for this. Anybody knows why?

--=20
Florent Thoumie
flz@FreeBSD.org
FreeBSD Committer

--=-HmqpF4p7JssWmYuhHtQH
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (FreeBSD)

iD8DBQBEftD1MxEkbVFH3PQRAmedAJ47CHhT5E1bfbsoCde0BbAl/SWcRACbBImq
iC/zykmnk9pE6h0hVGgAXyg=
=nD+V
-----END PGP SIGNATURE-----

--=-HmqpF4p7JssWmYuhHtQH--