From owner-freebsd-bugs@FreeBSD.ORG  Mon Jun 29 11:20:02 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C62A710656A4
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 29 Jun 2009 11:20:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 86C7C8FC15
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 29 Jun 2009 11:20:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n5TBK2q9057974
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 29 Jun 2009 11:20:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n5TBK2JQ057973;
	Mon, 29 Jun 2009 11:20:02 GMT (envelope-from gnats)
Resent-Date: Mon, 29 Jun 2009 11:20:02 GMT
Resent-Message-Id: <200906291120.n5TBK2JQ057973@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Sebastian Huber <sebastian.huber@embedded-brains.de>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 60E0A1065902
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon, 29 Jun 2009 11:17:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 4CA558FC15
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon, 29 Jun 2009 11:17:21 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n5TBHKIs097465
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 29 Jun 2009 11:17:20 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n5TBHKhX097464;
	Mon, 29 Jun 2009 11:17:20 GMT (envelope-from nobody)
Message-Id: <200906291117.n5TBHKhX097464@www.freebsd.org>
Date: Mon, 29 Jun 2009 11:17:20 GMT
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/136159: tsleep with PDROP in kthread_suspend()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jun 2009 11:20:03 -0000


>Number:         136159
>Category:       kern
>Synopsis:       tsleep with PDROP in kthread_suspend()
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 29 11:20:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Sebastian Huber
>Release:        -current
>Organization:
embedded brains GmbH
>Environment:
source code
>Description:
tsleep() with PDROP makes no sense.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: kern/kern_kthread.c
===================================================================
--- kern/kern_kthread.c	(revision 195153)
+++ kern/kern_kthread.c	(working copy)
@@ -350,7 +350,7 @@
 	 * or we'll end up timing out
 	 */
 	wakeup(td); /* traditional  place for kernel threads to sleep on */ /* XXX ?? */
-	return (tsleep(&td->td_flags, PPAUSE | PDROP, "suspkt", timo));
+	return (tsleep(&td->td_flags, PPAUSE, "suspkt", timo));
 }
 
 /*


>Release-Note:
>Audit-Trail:
>Unformatted: