Date: Mon, 29 Jun 2009 11:17:20 GMT From: Sebastian Huber <sebastian.huber@embedded-brains.de> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/136159: tsleep with PDROP in kthread_suspend() Message-ID: <200906291117.n5TBHKhX097464@www.freebsd.org> Resent-Message-ID: <200906291120.n5TBK2JQ057973@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 136159 >Category: kern >Synopsis: tsleep with PDROP in kthread_suspend() >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jun 29 11:20:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Sebastian Huber >Release: -current >Organization: embedded brains GmbH >Environment: source code >Description: tsleep() with PDROP makes no sense. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: kern/kern_kthread.c =================================================================== --- kern/kern_kthread.c (revision 195153) +++ kern/kern_kthread.c (working copy) @@ -350,7 +350,7 @@ * or we'll end up timing out */ wakeup(td); /* traditional place for kernel threads to sleep on */ /* XXX ?? */ - return (tsleep(&td->td_flags, PPAUSE | PDROP, "suspkt", timo)); + return (tsleep(&td->td_flags, PPAUSE, "suspkt", timo)); } /* >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906291117.n5TBHKhX097464>