From owner-cvs-src@FreeBSD.ORG Tue Nov 9 13:05:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 297CF16A4CE; Tue, 9 Nov 2004 13:05:04 +0000 (GMT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8483D43D46; Tue, 9 Nov 2004 13:05:03 +0000 (GMT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.13.1/8.13.1) with ESMTP id iA9D3tod051683; Tue, 9 Nov 2004 08:03:56 -0500 (EST) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)iA9D3tIB051680; Tue, 9 Nov 2004 13:03:55 GMT (envelope-from robert@fledge.watson.org) Date: Tue, 9 Nov 2004 13:03:55 +0000 (GMT) From: Robert Watson X-Sender: robert@fledge.watson.org To: John Baldwin In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: src-committers@FreeBSD.org cc: Alan Cox cc: cvs-src@FreeBSD.org cc: Mike Silbersack cc: cvs-all@FreeBSD.org cc: Stephan Uphoff Subject: Re: cvs commit: src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2004 13:05:04 -0000 On Tue, 9 Nov 2004, Robert Watson wrote: > > I've tried changing the store_rel() to just do a simple store since writes are > > ordered on x86, but benchmarks on SMP showed that it actually hurt. However, > > it would probably be good to at least do that for UP. The current patch to > > do it for all kernels is: Interestingly, I've now run through some more "macro" benchmarks. I saw a couple of percent improvement on UP from the change, but indeed, I saw a slight decrease in performance for the rapid packet send benchmark on SMP. So I guess my recommendation is to get this in the tree for UP, and see if we can figure out why it's having the slow-down effect on SMP. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Principal Research Scientist, McAfee Research