From owner-svn-src-head@freebsd.org Mon May 7 17:58:04 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6304FB8342; Mon, 7 May 2018 17:58:04 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 017958153F; Mon, 7 May 2018 17:58:03 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w47Hw03W057004; Mon, 7 May 2018 10:58:00 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w47Hw0FZ057003; Mon, 7 May 2018 10:58:00 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201805071758.w47Hw0FZ057003@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r333324 - in head/sys: amd64/amd64 conf In-Reply-To: To: Warner Losh Date: Mon, 7 May 2018 10:58:00 -0700 (PDT) CC: "Rodney W. Grimes" , "Conrad E. Meyer" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 17:58:04 -0000 [ Charset UTF-8 unsupported, converting... ] > On Mon, May 7, 2018 at 11:28 AM, Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer wrote: > > > > > > > On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes > > > > wrote: > > > > >> + * ws@tools.de (Wolfgang Solfrank, TooLs GmbH) +49-228-985800 > > > > > > > > > > If the original is by ws@tools.de, who is this version by? > > > > > Or is this simply copied from some other FreeBSD file? > > > > > > > > This is covered thoroughly in lines 1-10 of the commit email: > > > > > > > > > Author: mjg > > > > ... > > > > > memmove is repurposed bcopy (arguments swapped, return value added) > > > > > > > > > > It's also trivial to see from code comparison... It noticed it right away > > > while reviewing... > > > > I believe both you and Conrad are placing to much weight on the commit > > message and no weight on the comment. Someone reading the code is not > > going to have the context we presently have. > > > > Comments in code need to stand alone, without any context of commit > > message creating them, or code else where, unless they directly > > reference that code else where. > > > > The code is 95% Wolfgang's code with the removal of the xchg %edi,%esi at > the top and saving %edi into %r9 and restoring it to %rax before return. So > -1 line +3 lines for a ~45 line function that affected only the arg order > and return code.... The comment is entirely appropriate. Again, it is the comment that is very incomplete and ambigous, thankfully it has been corrected. -- Rod Grimes rgrimes@freebsd.org