Date: Mon, 7 May 2018 10:58:00 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Warner Losh <imp@bsdimp.com> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, "Conrad E. Meyer" <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333324 - in head/sys: amd64/amd64 conf Message-ID: <201805071758.w47Hw0FZ057003@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CANCZdfp-UbGcyECgNj7mm%2BXJC8eJ6rm1YLokckjGDmCU9ojusQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > On Mon, May 7, 2018 at 11:28 AM, Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > > On Mon, May 7, 2018 at 10:26 AM, Conrad Meyer <cem@freebsd.org> wrote: > > > > > > > On Mon, May 7, 2018 at 8:45 AM, Rodney W. Grimes > > > > <freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > > >> + * ws@tools.de (Wolfgang Solfrank, TooLs GmbH) +49-228-985800 > > > > > > > > > > If the original is by ws@tools.de, who is this version by? > > > > > Or is this simply copied from some other FreeBSD file? > > > > > > > > This is covered thoroughly in lines 1-10 of the commit email: > > > > > > > > > Author: mjg > > > > ... > > > > > memmove is repurposed bcopy (arguments swapped, return value added) > > > > > > > > > > It's also trivial to see from code comparison... It noticed it right away > > > while reviewing... > > > > I believe both you and Conrad are placing to much weight on the commit > > message and no weight on the comment. Someone reading the code is not > > going to have the context we presently have. > > > > Comments in code need to stand alone, without any context of commit > > message creating them, or code else where, unless they directly > > reference that code else where. > > > > The code is 95% Wolfgang's code with the removal of the xchg %edi,%esi at > the top and saving %edi into %r9 and restoring it to %rax before return. So > -1 line +3 lines for a ~45 line function that affected only the arg order > and return code.... The comment is entirely appropriate. Again, it is the comment that is very incomplete and ambigous, thankfully it has been corrected. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805071758.w47Hw0FZ057003>