Date: Tue, 4 Jul 2023 04:49:27 +0000 (UTC) From: Pedro Giffuni <pfg@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 4456846a1a0d - main - bin/date: Upgrade calculations Message-ID: <518821019.2139852.1688446167878@mail.yahoo.com> In-Reply-To: <CANCZdfo%2BAZYU0EzRtZv-mNQhGogUddD%2BgJijkJyrGS-SQ19jqA@mail.gmail.com> References: <202307040308.36438MTA093771@gitrepo.freebsd.org> <CANCZdfqMvf1QuS=fNQjRPe3YUbp1zPQW4aorh=VTRHk%2Bf_e8qg@mail.gmail.com> <1037448433.54513.1688441647903@mail.yahoo.com> <CANCZdfrSnS5Xq020jwsY-pgmTCJEn5Ka3Zr5vqt6OK%2Buawc4tA@mail.gmail.com> <1767168745.2134945.1688443634249@mail.yahoo.com> <CANCZdfo%2BAZYU0EzRtZv-mNQhGogUddD%2BgJijkJyrGS-SQ19jqA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_2139851_1304661400.1688446167877
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
OK done .. and you are right .. the fix was my responsibility .. if I didn=
't have the time to complete it I should have left it for a while longer in=
my disk :-(.
For the record, Dragonfly added incomplete support for the GNU -d option, b=
ut I didn't find that interesting, and I have no plans to merge that.
Pedro.
On Monday, July 3, 2023 at 11:37:08 PM GMT-5, Warner Losh <imp@bsdimp.c=
om> wrote: =20
=20
=20
On Mon, Jul 3, 2023, 10:07 PM Pedro Giffuni <pfg@freebsd.org> wrote:
(Sorry for top posting)
Oh yes, the analysis is fine, and it is quicker to fix than what I had in m=
ind.
I'll take a look at fixing it now, but due to external issues I may have to=
leave the fix for next weekend.
Ah great. I'll not have time to fix this... thanks for taking care of this.=
.. sorry if i was a It grumpy... it's been a day...
Warner
Pedro.
On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Losh <imp@bsdimp.c=
om> wrote: =20
=20
=20
On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <pfg@freebsd.org> wrote:
Hmm ...
Dragonfly has no armv7 or i386, so they didn't get it too wrong.I guess=C2=
=A0the int64_t would be a quick fix or another option, which I was considei=
rng, was to look at unsigning it but taking care of the edge cases ... I wa=
s too lazy for that.
Please go ahead and do the quick fix ;)
What makes you say it's a quick fix? If the calculations need 64 bits, int6=
4_t is the proper data type. How is that analysis wrong?
Also, it's tradition that you should fix it...
Warner =20
=20
------=_Part_2139851_1304661400.1688446167877
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<html><head></head><body><div class=3D"ydpc54ddde5yahoo-style-wrap" style=
=3D"font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:16px=
;"><div></div>
<div dir=3D"ltr" data-setdir=3D"false">OK done .. and you are right=
.. the fix was my responsibility .. if I didn't have the time to complete =
it I should have left it for a while longer in my disk :-(.</div><div dir=
=3D"ltr" data-setdir=3D"false"><br></div><div dir=3D"ltr" data-setdir=3D"fa=
lse">For the record, Dragonfly added incomplete support for the GNU -d opti=
on, but I didn't find that interesting, and I have no plans to merge that.<=
/div><div dir=3D"ltr" data-setdir=3D"false"><br></div><div dir=3D"ltr" data=
-setdir=3D"false">Pedro.</div><div dir=3D"ltr" data-setdir=3D"false"><br></=
div>
=20
</div><div id=3D"ydp4d5a4912yahoo_quoted_8450583316" class=3D"ydp4d=
5a4912yahoo_quoted">
<div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, s=
ans-serif;font-size:13px;color:#26282a;">
=20
<div>
On Monday, July 3, 2023 at 11:37:08 PM GMT-5, Warner Lo=
sh <imp@bsdimp.com> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div id=3D"ydp4d5a4912yiv5496367686"><div><div><div><b=
r clear=3D"none"><br clear=3D"none"><div class=3D"ydp4d5a4912yiv5496367686g=
mail_quote"><div dir=3D"ltr" class=3D"ydp4d5a4912yiv5496367686gmail_attr">O=
n Mon, Jul 3, 2023, 10:07 PM Pedro Giffuni <<a shape=3D"rect" href=3D"ma=
ilto:pfg@freebsd.org" rel=3D"nofollow" target=3D"_blank">pfg@freebsd.org</a=
>> wrote:<br clear=3D"none"></div><blockquote style=3D"margin:0 0 0 .8ex=
;border-left:1px #ccc solid;padding-left:1ex;" class=3D"ydp4d5a4912yiv54963=
67686gmail_quote"><div><div style=3D"font-family:Helvetica Neue, Helvetica,=
Arial, sans-serif;font-size:16px;"><div></div>
<div dir=3D"ltr">(Sorry for top posting)</div><div><br clear=3D"non=
e"></div><div dir=3D"ltr">Oh yes, the analysis is fine, and it is quicker t=
o fix than what I had in mind.</div><div dir=3D"ltr"><br clear=3D"none"></d=
iv><div dir=3D"ltr">I'll take a look at fixing it now, but due to external =
issues I may have to leave the fix for next weekend.</div></div></div></blo=
ckquote></div></div><div><br clear=3D"none"></div><div>Ah great. I'll not h=
ave time to fix this... thanks for taking care of this... sorry if i was a =
It grumpy... it's been a day...</div><div><br clear=3D"none"></div><div>War=
ner</div><div id=3D"ydp4d5a4912yiv5496367686yqtfd20868" class=3D"ydp4d5a491=
2yiv5496367686yqt0992661216"><div><br clear=3D"none"></div><div><div class=
=3D"ydp4d5a4912yiv5496367686gmail_quote"><blockquote style=3D"margin:0 0 0 =
.8ex;border-left:1px #ccc solid;padding-left:1ex;" class=3D"ydp4d5a4912yiv5=
496367686gmail_quote"><div><div style=3D"font-family:Helvetica Neue, Helvet=
ica, Arial, sans-serif;font-size:16px;"><div dir=3D"ltr">Pedro.</div><div><=
br clear=3D"none"></div><div><br clear=3D"none"></div>
=20
</div><div id=3D"ydp4d5a4912yiv5496367686m_-2495992665827709045ydp3=
9addca9yahoo_quoted_9236065441">
<div style=3D"font-family:'Helvetica Neue', Helvetica, Arial, s=
ans-serif;font-size:13px;color:#26282a;">
=20
<div>
On Monday, July 3, 2023 at 11:00:51 PM GMT-5, Warner Lo=
sh <<a shape=3D"rect" href=3D"mailto:imp@bsdimp.com" rel=3D"nofollow" ta=
rget=3D"_blank">imp@bsdimp.com</a>> wrote:
</div>
<div><br clear=3D"none"></div>
<div><br clear=3D"none"></div>
<div><div id=3D"ydp4d5a4912yiv5496367686m_-2495992665827709=
045ydp39addca9yiv4277734352"><div><div><div><br clear=3D"none"><br clear=3D=
"none"><div><div dir=3D"ltr">On Mon, Jul 3, 2023, 9:34 PM Pedro Giffuni <=
;<a shape=3D"rect" href=3D"mailto:pfg@freebsd.org" rel=3D"nofollow" target=
=3D"_blank">pfg@freebsd.org</a>> wrote:<br clear=3D"none"></div><blockqu=
ote style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;=
"><div><div style=3D"font-family:Helvetica Neue, Helvetica, Arial, sans-ser=
if;font-size:16px;"><div></div>
<div dir=3D"ltr">Hmm ...</div><div dir=3D"ltr"><br clear=3D"none"><=
/div><div dir=3D"ltr">Dragonfly has no armv7 or i386, so they didn't get it=
too wrong.</div><div dir=3D"ltr">I guess <span><span style=3D"color:r=
gb(0,0,0);font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-siz=
e:16px;">the int64_t would be a quick fix or</span></span> another option, =
which I was consideirng, was to look at unsigning it but taking care of the=
edge cases ... I was too lazy for that.</div><div><br clear=3D"none"></div=
><div dir=3D"ltr">Please go ahead and do the quick fix ;)</div></div></div>=
</blockquote></div></div><div><br clear=3D"none"></div><div>What makes you =
say it's a quick fix? If the calculations need 64 bits, int64_t is the prop=
er data type. How is that analysis wrong?</div><div><br clear=3D"none"></di=
v><div>Also, it's tradition that you should fix it...</div><div><br clear=
=3D"none"></div><div>Warner</div></div><div id=3D"ydp4d5a4912yiv5496367686m=
_-2495992665827709045ydp39addca9yiv4277734352yqtfd43229">
</div></div></div></div>
</div>
</div></div></blockquote></div></div></div></div><div id=3D"ydp4d5a=
4912yiv5496367686yqtfd23873" class=3D"ydp4d5a4912yiv5496367686yqt0992661216=
">
</div></div></div></div>
</div>
</div></body></html>
------=_Part_2139851_1304661400.1688446167877--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?518821019.2139852.1688446167878>