From owner-cvs-src@FreeBSD.ORG Wed Nov 3 20:32:49 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E99016A4E2; Wed, 3 Nov 2004 20:32:49 +0000 (GMT) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id D5CF843D5F; Wed, 3 Nov 2004 20:32:48 +0000 (GMT) (envelope-from glebius@freebsd.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.12.11/8.12.8) with ESMTP id iA3KWluQ005262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Nov 2004 23:32:47 +0300 (MSK) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.sick.ru (8.12.11/8.12.11/Submit) id iA3KWkKv005261; Wed, 3 Nov 2004 23:32:47 +0300 (MSK) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@freebsd.org using -f Date: Wed, 3 Nov 2004 23:32:46 +0300 From: Gleb Smirnoff To: Luigi Rizzo Message-ID: <20041103203246.GD5033@cell.sick.ru> References: <200411031411.iA3EBIqL012134@repoman.freebsd.org> <418905E5.1050605@freebsd.org> <20041103082806.C49241@xorpc.icir.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20041103082806.C49241@xorpc.icir.org> User-Agent: Mutt/1.5.6i cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Scott Long cc: Poul-Henning Kamp cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2004 20:32:49 -0000 On Wed, Nov 03, 2004 at 08:28:06AM -0800, Luigi Rizzo wrote: L> > I think that in general we can start eyeing a lot of similar verbosity L> > in all of our drivers, both at boot and at runtime. For example most L> > nic drivers print out their MAC and all of their possible negotiation L> > rates on attach. This same info can be obtained from ifconfig. Why L> > clutter the boot with it? L> L> because sometimes you might need to enable some MAC-based filter L> before you have a chance to access the box. e.g. to set dhcp/bootp L> anbd the like. L> L> A bit of verbosity is useful, you can always switch to splash screens L> if you don't like them. L> L> I think the link-up/link-down thing is different because it L> happens not just at boot but also whenever the link status L> changes (e.g. when a spanning tree on a switch detects a L> reconfiguration), and this is annoying on the console. My 1 penny: I completely agree with Luigi at this point. So my vote is: keep initialization printfs as is, remove any runtime printfs. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE