From owner-freebsd-ports@freebsd.org Thu Aug 2 19:04:54 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3405C104ACAF for ; Thu, 2 Aug 2018 19:04:54 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic313-11.consmr.mail.ne1.yahoo.com (sonic313-11.consmr.mail.ne1.yahoo.com [66.163.185.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BF6C176991 for ; Thu, 2 Aug 2018 19:04:53 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: KH9cA_MVM1nWBOUmpT5Omzu8LPnDB8PFsWrY6nL3VG1I3E.kIWxsJLOn5pe3bQO nQTm2a0bR8zd7cpxXv0XKyDC.DnsbQXlfnQMStEOCQwuxbKQ4yjq1HB5TuIvlUM41RXbvDSgIF_0 bIY3dY36nNxYo.CzYoROjFVdp6I.SRkJBcMsrF0.JJdrWRstDuD5a0rqYor0u48XGqq7CR1Q6ORs cP94uPF.wCfpjvnWtKKR8Q6u88qpVB0cEeTaR5M9vR_8JraCcmfHCmByCsIO9FqzLRVKKguyJhaY JumFjwiSunrnof5xzZzPscJWZ7.g3HCZE7aGmqlxbsPs7QcEVKUtBSnXbPBeNY.8Weh3NL.jsewB WIPt9eWPKuja.z31pzokxkFYF4.BTqeh8caO9_sqL_iyiQVBAOezUeuS2ZcKPzT7Acp8iy00bcHQ PeW9_UQ0nGok7OVCRh6tylfS..t41DlXhr2F8w6vZMmyWsRXYqwxMPhOmUX3bneFOpgNtzzRjiyo GSQhwr5lEHVD6PUDvlpnPE0cfKq3B2lizNLqmre7j5qBAEfJjelNZqs.8fE99R7e6sRDcVVrGeik r6mB1CEQ_BDsDWjDCHdcMDO8nR8IuYEHole3783fKDskKX9jicivrKdQvcRAqi4zzPncnYHABmWl fix72S1xLvYrLeLq7Iwt3iTtPOM3BQbKSOE8fDRtGP6YGPyMhha4uZU5yJ6nekgsXoYW_OE2bjkB UAShAs1mYDo8AoKuBPrjACyYtj5yVYZ0HxxYmRezHYd_N91AvqCcYIdy9CCv.cm_Rqxu5XPPvlkw 0wms.fKEZQ8GF6GZdx2ZymzeBwcpWux1jYN5J7LmhGjfSe_0wYaBXVyxfwMWMZvMjZOmDu5lj46o IZWTWSrcjmdUr7KmDAQAv.xauR42.ysQeYMwLi3bDfUWNRPVNu_vt3Y9suqLay.sz0OEFYHzBtsU 4WOeVRcDvQ7llaIp5zrzIlji5YKazGLAeaNKrnyBiVC.JqMUw5376ieCkkZjK02cZOBkjbr7pEcR 7J45tAMQl5PojWBewNRC28w-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 2 Aug 2018 19:04:46 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp423.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID b0a40bffcc42cae949cf64c94fc6994f; Thu, 02 Aug 2018 19:04:45 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: Removing objdump breaks GCC configure From: Mark Millard In-Reply-To: <0F5EA96D-7C2E-403C-A8D0-530D2EA4B682@yahoo.com> Date: Thu, 2 Aug 2018 12:04:43 -0700 Cc: Gerald Pfeifer , mat@FreeBSD.org, FreeBSD Ports , Bryan Drewery Content-Transfer-Encoding: quoted-printable Message-Id: References: <3A54CD6F-FEE9-4813-97B8-76A3E619D7F4@yahoo.com> <884de41d-011e-a025-bfec-4e61b5546336@FreeBSD.org> <47AE95CB-1BD7-42DA-AA17-3EC0252FAF59@yahoo.com> <381572D9-6338-4DF4-B731-860557B2F666@yahoo.com> <6047CF45-733C-4331-B640-4A501F48B698@yahoo.com> <73D4B099-C694-489C-AD17-89F3139058A6@yahoo.com> <0F5EA96D-7C2E-403C-A8D0-530D2EA4B682@yahoo.com> To: John Baldwin , Ed Maste X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 19:04:54 -0000 [I also ran into the issue for sysutils/u-boot-pine64 builds in my context (WITHOUT_BINUTILS).] On 2018-Aug-1, at 3:08 PM, Mark Millard wrote: > On 2018-Aug-1, at 1:29 PM, John Baldwin wrote: >=20 >> On 7/29/18 9:02 PM, Mark Millard wrote: >>>> It looks like configure uses objdump (without a path-prefix) for >>>> export_sym_check : >>>>=20 >>>> case "${host}" in >>>> *-*-darwin*) >>>> if test x$build =3D x$host; then >>>> export_sym_check=3D"nm${exeext} -g" >>>> elif test x$host =3D x$target; then >>>> export_sym_check=3D"$gcc_cv_nm -g" >>>> else >>>> export_sym_check=3D >>>> fi >>>> ;; >>>> *) >>>> if test x$build =3D x$host; then >>>> export_sym_check=3D"objdump${exeext} -T" >>>> elif test x$host =3D x$target; then >>>> export_sym_check=3D"$gcc_cv_objdump -T" >>>> else >>>> export_sym_check=3D >>>> fi >>>> ;; >>>> esac >>>>=20 >>>> Note that this would not be the objdump from = devel/powerpc64-binutils >>>> but one for amd64 (in my example) such as from devel/binutils or >>>> devel/amd64-binutils for my context. >>>>=20 >>>> Note the lack of any alternative to objdump use (for build matching = host). >>>=20 >>> # svnlite diff /usr/ports/devel/powerpc64-gcc/Makefile >>> Index: /usr/ports/devel/powerpc64-gcc/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- /usr/ports/devel/powerpc64-gcc/Makefile (revision 475470) >>> +++ /usr/ports/devel/powerpc64-gcc/Makefile (working copy) >>> @@ -16,7 +16,8 @@ >>> LIB_DEPENDS=3D libgmp.so:math/gmp \ >>> libmpfr.so:math/mpfr \ >>> libmpc.so:math/mpc >>> -BUILD_DEPENDS=3D ${BU_PREFIX}-as:devel/${PKGNAMEPREFIX}binutils >>> +BUILD_DEPENDS=3D ${BU_PREFIX}-as:devel/${PKGNAMEPREFIX}binutils \ >>> + objdump:devel/binutils >>> RUN_DEPENDS=3D ${BU_PREFIX}-as:devel/${PKGNAMEPREFIX}binutils >>>=20 >>> USES=3D gmake iconv libtool tar:xz makeinfo compiler >>=20 >> Context trimmed a bit, subject changed, and I've added Ed to the cc = as he's >> the one who removed objdump. It seems that GCC at least has a hidden >> dependency on objdump. Ed, were the lang/gcc* ports updated when = objdump >> was removed to list it as dependency for the plugin functionality? = If not, >> they might also need a similar fix. >=20 > devel/-gcc cross compiler builds: > Cross builds required the builder's objdump and possibly the target's > too (as well as other target binutils). But for the target that is the = same > in devel/-binutils and devel/-gcc and likely was already > covered. >=20 > (I may have missed other builder-binutil tool references but know > objdump for sure.) >=20 > When the builder architecture is also the target as part of the > port definition (all lang/gcc* ?), devel/binutils is likely already > required and then covers all objdump use as far as I can tell. >=20 > (I'm not sure if the normal package builders are omitting system > binutils yet or if they might always have devel/binutils installed.) >=20 >>> Note: Various other autoconfig .ac files for various ports >>> might also make assumptions about some binutils for the >>> building archteiture, assumptions that various FreeBSD >>> architectures need not automatically provide for: ones for >>> which WITHOUT_BINUTILS=3D can be used. >>=20 >> I believe Ed did an exp-run before disabling objdump by default (or = maybe >> that change is still pending?). I'm not sure if that exp-run would = catch >> more subtle changes like this. >=20 > My guess is that only ports with cross-build abilities might have the > "some builder binutils tool(s) needed" issue. I'm now using: # svnlite diff /usr/ports/sysutils/u-boot-master/Makefile Index: /usr/ports/sysutils/u-boot-master/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /usr/ports/sysutils/u-boot-master/Makefile (revision 476026) +++ /usr/ports/sysutils/u-boot-master/Makefile (working copy) @@ -21,6 +21,7 @@ dtc>=3D1.4.1:sysutils/dtc \ mkimage:sysutils/u-boot-tools BUILD_DEPENDS+=3D ${COMPILER}:devel/${COMPILER} +BUILD_DEPENDS+=3D objdump:devel/binutils =20 USES=3D bison gmake python:2.7,build shebangfix tar:bz2 BINARY_ALIAS=3D bison=3D${LOCALBASE}/bin/bison = dtc=3D${LOCALBASE}/bin/dtc sed=3Dgsed swig=3Dswig3.0 in order for sysutils/u-boot-pine64 to build in my context that is based on WITHOUT_BINUTILS . Interestingly: before this change the following built fine: sysutils/u-boot-rpi3 | u-boot-rpi3-2018.07_1 sysutils/u-boot-rpi2 | u-boot-rpi2-2018.07_1 sysutils/u-boot-sinovoip-bpi-m3 | u-boot-sinovoip-bpi-m3-2018.07_1 but sysutils/u-boot-pine64 did not. The use of some builder environment tool(s) is specific to u-boot-pine64 (of the 4 u-boot-* 's). I've not isolated the sysutils/u-boot-pine64 code that puts some builder environment tool(s) to use. So I've not formally shown root cause for this case. I submitted https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230288 for this issue (before I showed BUILD_DEPENDS was at least a workaround). =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)