From nobody Sun Jun 28 00:30:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gnr0T55MZz6jDJr for ; Sun, 28 Jun 2026 00:30:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gnr0S74vDz3dKw for ; Sun, 28 Jun 2026 00:30:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782606617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8jIXvlEDaw9psJ5GmqijAXfIf6zssxnS3N3BS5jrAhA=; b=WDM0t5jRS/6aljpHb7a/AzVbdU1WzybWf8l3fg8y483GcQUlJeBFpFuN6TD77xgVgrUNwa 8T0l2Bn/2o55n/f9ThZvST/DnXZgSB3+ieu3Rf2ntuGRNv2z8fTyvzauoCcNQgw6xypMbD 55KWSp3L2cM5QSwPHZ6OWBLPv8TBn7Vy7cuzPQBRpqt+4xeiqEaaTcvhVIwaVjMguLEjye 4uxglcuhTzZZUaqHFKD/3/nbX91EbPbjOAYqSCEQsB/FqaZswyP5oMa/nLuDs3OH2AkLyp cr1Jy9DT8ReTqkoY+p4qAyg3qeicxw3ytRwDG64k6n5s66qt6SoQxhNL15G45w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782606617; a=rsa-sha256; cv=none; b=UtebBMDiLS8P0TsK+FYrCzopzQlcaIMaMz4pVFkNt9dX9M3tp4KXVPtz+2vO7PVDICFuES UIjDJl3qpVbl5OZYRacGI2GJDZ6wfRSNAZ3REhzC4j9heAokemJRahleqhjMJvt6wXrXTo OnoN6sEWkfLBl3/sgkOUoDeed1lJ4PdH+cgdUMaB+wweJzqxjn1zz6LaycbIez4G9KODdN F8HqqlHw+cx66NHSM8jncm4Lr/m4UXD3OvxSvJh1jG3UbYEn8nejGM775ThfTMwPsuaKsS 2PQqngyTmhl29Shjh4XrGDhYMPk8kymnkxdRWf4IWz7bPv6XSMJyC+8mphhcfw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782606617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8jIXvlEDaw9psJ5GmqijAXfIf6zssxnS3N3BS5jrAhA=; b=cmfhk33aBPjRNxGKlhQ0AO11KntIu3MP0iK1gPJgxHdnje0q0FrBCkwkF9wUhn9qu3d6T4 uq8r8Lmq+7LhPVFuByFGsjPIpVbdeg4HgP1iEuU/9rVPtxS4YC5OdvI1APurU4XzKCdbQw 5FKfybxQPFrbJ7/OKb80+sPPUGbjqDOZIrBiBEFNfJa+0u0zYNp4hOrfpdDeNsaUrXGJ9q R6rqiIlT0xE6vFx4WFwLvvmGYIl2G/CKaW8iCj7eteacOPzII1x8+rRm3u78yXPAKb5Av+ rw9tL1s5zZ2Axvmh0BOvGUCKR8408YAvMPWyLm9xLYzoIdCuNZz91hL6j63yZw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gnr0S68pLznC7 for ; Sun, 28 Jun 2026 00:30:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3e9fd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 28 Jun 2026 00:30:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: d7d5337291c9 - stable/14 - procfs, linprocfs: ensure target process vmspace stability List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d7d5337291c983ba969e24c95df0bcab46b44621 Auto-Submitted: auto-generated Date: Sun, 28 Jun 2026 00:30:16 +0000 Message-Id: <6a406b18.3e9fd.7ce9870c@gitrepo.freebsd.org> The branch stable/14 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=d7d5337291c983ba969e24c95df0bcab46b44621 commit d7d5337291c983ba969e24c95df0bcab46b44621 Author: Konstantin Belousov AuthorDate: 2026-06-07 18:48:59 +0000 Commit: Konstantin Belousov CommitDate: 2026-06-28 00:29:04 +0000 procfs, linprocfs: ensure target process vmspace stability (cherry picked from commit 5db31f1b47b586a5091eb41fc957236f28b78dba) --- sys/compat/linprocfs/linprocfs.c | 16 +++++----------- sys/fs/procfs/procfs_map.c | 17 +++++++---------- sys/fs/procfs/procfs_mem.c | 6 +----- 3 files changed, 13 insertions(+), 26 deletions(-) diff --git a/sys/compat/linprocfs/linprocfs.c b/sys/compat/linprocfs/linprocfs.c index 1171e2c98342..f2dd38576205 100644 --- a/sys/compat/linprocfs/linprocfs.c +++ b/sys/compat/linprocfs/linprocfs.c @@ -1313,19 +1313,13 @@ linprocfs_doprocmaps(PFS_FILL_ARGS) struct vattr vat; bool private; - PROC_LOCK(p); - error = p_candebug(td, p); - PROC_UNLOCK(p); - if (error) - return (error); - if (uio->uio_rw != UIO_READ) return (EOPNOTSUPP); - error = 0; - vm = vmspace_acquire_ref(p); - if (vm == NULL) - return (ESRCH); + error = proc_vmspace_ref(td, p, PRVM_BLOCK_EXEC | PRVM_CHECK_DEBUG, + &vm); + if (error != 0) + return (error); if (SV_CURPROC_FLAG(SV_LP64)) l_map_str = l64_map_str; @@ -1423,7 +1417,7 @@ linprocfs_doprocmaps(PFS_FILL_ARGS) } } vm_map_unlock_read(map); - vmspace_free(vm); + proc_vmspace_unref(td, p, PRVM_CHECK_DEBUG | PRVM_BLOCK_EXEC, vm); return (error); } diff --git a/sys/fs/procfs/procfs_map.c b/sys/fs/procfs/procfs_map.c index db6b225f6426..5ccef979856b 100644 --- a/sys/fs/procfs/procfs_map.c +++ b/sys/fs/procfs/procfs_map.c @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include @@ -95,15 +96,14 @@ procfs_doprocmap(PFS_FILL_ARGS) bool wrap32; #endif - PROC_LOCK(p); - error = p_candebug(td, p); - PROC_UNLOCK(p); - if (error) - return (error); - if (uio->uio_rw != UIO_READ) return (EOPNOTSUPP); + error = proc_vmspace_ref(td, p, PRVM_BLOCK_EXEC | PRVM_CHECK_DEBUG, + &vm); + if (error != 0) + return (error); + #ifdef COMPAT_FREEBSD32 wrap32 = false; if (SV_CURPROC_FLAG(SV_ILP32)) { @@ -113,9 +113,6 @@ procfs_doprocmap(PFS_FILL_ARGS) } #endif - vm = vmspace_acquire_ref(p); - if (vm == NULL) - return (ESRCH); map = &vm->vm_map; vm_map_lock_read(map); VM_MAP_ENTRY_FOREACH(entry, map) { @@ -240,6 +237,6 @@ procfs_doprocmap(PFS_FILL_ARGS) } } vm_map_unlock_read(map); - vmspace_free(vm); + proc_vmspace_unref(td, p, PRVM_BLOCK_EXEC | PRVM_CHECK_DEBUG, vm); return (error); } diff --git a/sys/fs/procfs/procfs_mem.c b/sys/fs/procfs/procfs_mem.c index 50db7d3a0b96..5fc0c1acf140 100644 --- a/sys/fs/procfs/procfs_mem.c +++ b/sys/fs/procfs/procfs_mem.c @@ -61,11 +61,7 @@ procfs_doprocmem(PFS_FILL_ARGS) if (uio->uio_resid == 0) return (0); - PROC_LOCK(p); - error = p_candebug(td, p); - PROC_UNLOCK(p); - if (error == 0) - error = proc_rwmem(p, uio, 0); + error = proc_rwmem(p, uio, PRVM_CHECK_DEBUG | PRVM_BLOCK_EXEC); return (error); }