From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Dec 26 19:00:21 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C8284106564A for ; Mon, 26 Dec 2011 19:00:21 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 915AF8FC18 for ; Mon, 26 Dec 2011 19:00:21 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBQJ0LBB058800 for ; Mon, 26 Dec 2011 19:00:21 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBQJ0Lx7058798; Mon, 26 Dec 2011 19:00:21 GMT (envelope-from gnats) Resent-Date: Mon, 26 Dec 2011 19:00:21 GMT Resent-Message-Id: <201112261900.pBQJ0Lx7058798@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Foster Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C184F106564A for ; Mon, 26 Dec 2011 18:52:04 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id AB4958FC08 for ; Mon, 26 Dec 2011 18:52:04 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id pBQIq4PT035565 for ; Mon, 26 Dec 2011 18:52:04 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id pBQIq4dh035564; Mon, 26 Dec 2011 18:52:04 GMT (envelope-from nobody) Message-Id: <201112261852.pBQIq4dh035564@red.freebsd.org> Date: Mon, 26 Dec 2011 18:52:04 GMT From: Mark Foster To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/163632: update audio/firefly to fix itunes 10.5.2 compatibility X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2011 19:00:22 -0000 >Number: 163632 >Category: ports >Synopsis: update audio/firefly to fix itunes 10.5.2 compatibility >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Mon Dec 26 19:00:21 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Mark Foster >Release: 8 >Organization: >Environment: >Description: Included patch fixes a problem with itunes 10.5.2 >How-To-Repeat: >Fix: apply patch Patch attached with submission follows: diff -ruN firefly/Makefile firefly_new/Makefile --- firefly/Makefile 2011-09-23 15:20:59.000000000 -0700 +++ firefly_new/Makefile 2011-12-25 18:19:20.000000000 -0800 @@ -6,7 +6,7 @@ PORTNAME= firefly PORTVERSION= 1696 -PORTREVISION= 4 +PORTREVISION= 5 CATEGORIES= audio MASTER_SITES= http://nightlies.fireflymediaserver.org/nightlies/svn-${PORTVERSION}/ \ http://www.magnesium.net/~mdf/distfiles/ diff -ruN firefly/files/patch-out-daap.c firefly_new/files/patch-out-daap.c --- firefly/files/patch-out-daap.c 1969-12-31 16:00:00.000000000 -0800 +++ firefly_new/files/patch-out-daap.c 2011-12-18 20:22:05.000000000 -0800 @@ -0,0 +1,25 @@ +@DPATCH@ +--- src/plugins/out-daap.c 2007-10-13 15:10:06.000000000 -0700 ++++ src/plugins/out-daap.c.new 2011-10-16 18:08:53.207764000 -0700 +@@ -1392,11 +1393,9 @@ + + size = sizeof(servername); + pi_server_name(servername,&size); +- // supports_update = conf_get_int("daap","supports_update",1); ++ supports_update = pi_conf_get_int("daap","supports_update",1); + + actual_length=139 + (int) strlen(servername); +- if(!supports_update) +- actual_length -= 9; + + if(actual_length > sizeof(server_info)) { + pi_log(E_FATAL,"Server name too long.\n"); +@@ -1434,6 +1433,8 @@ + current += dmap_add_int(current,"msdc",1); /* 12 */ + + if(supports_update) ++ current += dmap_add_char(current,"msup",1); /* 9 */ ++ else + current += dmap_add_char(current,"msup",0); /* 9 */ + + out_daap_output_start(pwsc,ppi,actual_length); >Release-Note: >Audit-Trail: >Unformatted: