From owner-freebsd-current@FreeBSD.ORG Wed Aug 23 11:06:23 2006 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC60616A4DD for ; Wed, 23 Aug 2006 11:06:23 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id F070A43D45 for ; Wed, 23 Aug 2006 11:06:22 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k7NB6KCK075202 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Aug 2006 15:06:20 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k7NB6Jks075201; Wed, 23 Aug 2006 15:06:19 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 23 Aug 2006 15:06:19 +0400 From: Gleb Smirnoff To: Pyun YongHyeon Message-ID: <20060823110619.GL96644@cell.sick.ru> References: <20060822042023.GC12848@cdnetworks.co.kr> <20060823093741.GF96644@FreeBSD.org> <20060823095504.GI17902@cdnetworks.co.kr> <20060823100420.GG96644@cell.sick.ru> <20060823105118.GJ17902@cdnetworks.co.kr> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060823105118.GJ17902@cdnetworks.co.kr> User-Agent: Mutt/1.5.6i Cc: freebsd-current@FreeBSD.org Subject: Re: call for bge(4) testers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2006 11:06:23 -0000 On Wed, Aug 23, 2006 at 07:51:18PM +0900, Pyun YongHyeon wrote: P> > P> Its sole purpose is to reinitialize hardware for real watchdog P> > P> timeouts. It's not fix for general watchdog timeouts. As I said other P> > P> mails, the fake watchdog timeout(losing Tx interrupts) for hardwares P> > P> with Tx interrupt moderation capability could be normal thing. So I P> > P> just want to know bge(4) also has the same feature(bug). P> > P> > According to several emails about em(4) fake watchdog timeouts, the P> > problem can be fixed by setting debug.mpsafenet=0. This makes me think P> > that the problem isn't caused by TX interrupt moderation, but some race P> > in the kernel. Really, if_slowtimo() doesn't acquire driver lock before P> > checking and modifying the if_timer field. P> > P> P> Hmm... I didn't say the problem was caused by TX interrupt moderation. P> I can't sure but I'm under the impression it has *two* different issues. P> If you think fake watchdog timeout fix is not adequate one please P> let me know. I'll backout the change if you want. I don't think you should backout it until we find a solution. However, I'd ask you don't MFC it. P> > Afaik, NIC drivers that can do interrupt moderation should set a timer P> > to a sane value, based on interrupt moderation settings, so that the P> > watchdog won't be ever called fakely. P> P> Yes. Normally it should. But I saw the issues on Marvell Yukon too. Does Marvell Yukon have interrupt moderation? -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE